From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA9DDC43331 for ; Wed, 1 Apr 2020 15:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 814A920658 for ; Wed, 1 Apr 2020 15:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733231AbgDAP6U (ORCPT ); Wed, 1 Apr 2020 11:58:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:46698 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732980AbgDAP6U (ORCPT ); Wed, 1 Apr 2020 11:58:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 75C37AC92; Wed, 1 Apr 2020 15:58:18 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 65771DA727; Wed, 1 Apr 2020 17:57:44 +0200 (CEST) Date: Wed, 1 Apr 2020 17:57:44 +0200 From: David Sterba To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Chris Mason , Josef Bacik , David Sterba , "open list:BTRFS FILE SYSTEM" Subject: Re: [PATCH 5/7] btrfs: Add missing annotation for btrfs_lock_cluster() Message-ID: <20200401155744.GU5920@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Jules Irenge , linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Chris Mason , Josef Bacik , David Sterba , "open list:BTRFS FILE SYSTEM" References: <0/7> <20200331204643.11262-1-jbi.octave@gmail.com> <20200331204643.11262-6-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331204643.11262-6-jbi.octave@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2020 at 09:46:41PM +0100, Jules Irenge wrote: > Sparse reports a warning at btrfs_lock_cluster() > > warning: context imbalance in btrfs_lock_cluster() > - wrong count > > The root cause is the missing annotation at btrfs_lock_cluster() > Add the missing __acquires(&cluster->refill_lock) annotation. > > Signed-off-by: Jules Irenge Thanks, I'll add it to devel queue.