From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: turn of_pinctrl_get() into a static inline
Date: Wed, 1 Apr 2020 19:18:10 +1100 [thread overview]
Message-ID: <20200401191810.1c06ead6@canb.auug.org.au> (raw)
In-Reply-To: <20200401190810.7a2cfa07@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
Hi all,
On Wed, 1 Apr 2020 19:08:10 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> This avoids the overheads of an EXPORTed function.
>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/pinctrl/devicetree.c | 6 ------
> include/linux/pinctrl/pinctrl.h | 9 +++------
> 2 files changed, 3 insertions(+), 12 deletions(-)
>
> This is not even build tested, but is this what you meant, Geert?
Actually this won't work because get_pinctrl_dev_from_of_node() is
declared in the private header file drivers/pinctrl/core.h :-(
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-01 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 8:08 Stephen Rothwell
2020-04-01 8:18 ` Stephen Rothwell [this message]
2020-04-01 8:20 ` Linus Walleij
2020-04-01 8:26 ` Geert Uytterhoeven
2020-04-01 8:43 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401191810.1c06ead6@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®