From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244A6C43331 for ; Thu, 2 Apr 2020 16:40:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7DBA20757 for ; Thu, 2 Apr 2020 16:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fH8o+GZD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389877AbgDBQkD (ORCPT ); Thu, 2 Apr 2020 12:40:03 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:34210 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389072AbgDBQkC (ORCPT ); Thu, 2 Apr 2020 12:40:02 -0400 Received: by mail-pf1-f196.google.com with SMTP id 23so2017942pfj.1 for ; Thu, 02 Apr 2020 09:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=P5P7+32EPNiTA9W/bPQnunX4XIHQIJgt5gQH7DdKhy0=; b=fH8o+GZDZ1xdsVdHSi6MAupKO7i5SOOdhKbMy9EC42AcredyeAYuEr60QU+fttr6C7 M2hu1qmBT0E9kEN76oM60aZ/2lEdUGRNSJhnMJgML3APaBmfOp6cNgas0HOFLn7YCJ9t RwvAvDwKlwACh5Y2WaH8SYappE+KxFzPYG22EvIPo0pYp4eYGp52pNwS8JUBHX39jpGn KyyV+sycOit5HZK8sukkfuVL/Bfn0cBmW79zilVLgTeAKHW5n0VQGehTG0J11yLPVzKS JdSyKtBiFPzQ7ho0Qfjc201wn6fV1KNo4fb4K4jM1Jya+7jxx7diX9cQyFo2tgDVbssA TyQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P5P7+32EPNiTA9W/bPQnunX4XIHQIJgt5gQH7DdKhy0=; b=fybLpQvstKuiPLVZXPTpgKmobQ3Ap844yHt/9iZzEv5GnXr2QoCd4SxB3bS/gIm44T bYQZn0r3mhDH8puw4maItcn0rHKzwA+QIDfBzkY5LMwVKZiS2wRa5LEK9xs6/CCVW3bK O8pS4FZ//bTRTGI3o+ZXFXZZXSQUg3+koy/rlta2ndP4GUT77HP1wAJlWtuljk6gjuNZ bMqO0NwdtVzgaELPRQYOFLbkXV9AP1pbdehb+MRg0mIlQuoUjv8CwCAukX7DKRjsd+oa Efb22OmrTtNnVL/1yddTzLot327mGBU4QJCQNP2mymDGNJSCGrbMZYm6PhaCRq8afdFl 09rw== X-Gm-Message-State: AGi0PuYE3rEsKoM+z1xoyR631Xrttc9f5jiAvd1wS7LZ16CnxAAxd+hk qc4+A3IgL74hQBZmkPqKucudUA== X-Google-Smtp-Source: APiQypKH0DXiDCoSWxCJ+loJoi3QVtbfhkTZ6FkNR9ShOim7iSVt2e1XqX4CIaEPQbwY6vh2ItkDDg== X-Received: by 2002:a05:6a00:c8:: with SMTP id e8mr3777718pfj.131.1585845601274; Thu, 02 Apr 2020 09:40:01 -0700 (PDT) Received: from google.com ([2620:15c:2ce:0:9efe:9f1:9267:2b27]) by smtp.gmail.com with ESMTPSA id ci18sm4102094pjb.23.2020.04.02.09.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 09:40:00 -0700 (PDT) Date: Thu, 2 Apr 2020 09:39:57 -0700 From: Fangrui Song To: 'Nick Desaulniers' via Clang Built Linux Cc: Masahiro Yamada , Nathan Chancellor , Linux Kbuild mailing list , Linux Kernel Mailing List , Sandeep Patil Subject: Re: [PATCH v2] Makefile.llvm: simplify LLVM build Message-ID: <20200402163957.lqgr3tpc4z7ish5e@google.com> References: <20200317215515.226917-1-ndesaulniers@google.com> <20200327224246.GA12350@ubuntu-m2-xlarge-x86> <20200330190312.GA32257@ubuntu-m2-xlarge-x86> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-04-01, 'Nick Desaulniers' via Clang Built Linux wrote: >On Tue, Mar 31, 2020 at 11:11 PM Masahiro Yamada wrote: >> >> On Wed, Apr 1, 2020 at 3:39 AM Nick Desaulniers wrote: >> > >> > On Mon, Mar 30, 2020 at 11:25 PM Masahiro Yamada wrote: >> > > >> > > Having both LLVM_DIR and LLVM_SUFFIX seems verbose. >> > >> > I agree, so maybe just LLVM=y, and we can support both non-standard >> > locations and debian suffixes via modifications to PATH. >> >> >> >> OK, so we will start with the boolean switch 'LLVM'. >> >> People can use PATH to cope with directory path and suffixes. > >Sounds good, we will modify our CI to use PATH modifications rather >than suffixes. We can even do that before such a patch to Makefile >exists. The proposed LLVM=1 + PATH scheme looks good to me. There seems to be one issue. OBJSIZE=llvm-objsize added in commit fcf1b6a35c16ac500fa908a4022238e5d666eabf "Documentation/llvm: add documentation on building w/ Clang/LLVM" is wrong. The tool is named llvm-size. OBJSIZE is only used once: arch/s390/scripts/Makefile.chkbss 14: if ! $(OBJSIZE) --common $< | $(AWK) 'END { if ($$3) exit 1 }'; then \