From: Bernardo Perez Priego <bernardo.perez.priego@intel.com>
To: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Nick Crews <ncrews@chromium.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Daniel Campello <campello@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] platform/chrome: wilco_ec: Provide correct output format to 'h1_gpio' file
Date: Thu, 2 Apr 2020 15:33:30 -0700 [thread overview]
Message-ID: <20200402223331.28300-1-bernardo.perez.priego@intel.com> (raw)
In-Reply-To: <20200313232720.22364-1-bernardo.perez.priego@intel.com>
Function 'h1_gpio_get' is receiving 'val' parameter of type u64,
this is being passed to 'send_ec_cmd' as type u8, thus, result
is stored in least significant byte. Due to output format,
the whole 'val' value was being displayed when any of the most
significant bytes are different than zero.
This fix will make sure only least significant byte is displayed
regardless of remaining bytes value.
Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com>
---
Changes in v2:
- Keep original format and apply mask instead to resolve warning
drivers/platform/chrome/wilco_ec/debugfs.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c b/drivers/platform/chrome/wilco_ec/debugfs.c
index df5a5f6c3ec6..a812788a0bdc 100644
--- a/drivers/platform/chrome/wilco_ec/debugfs.c
+++ b/drivers/platform/chrome/wilco_ec/debugfs.c
@@ -208,7 +208,12 @@ static int send_ec_cmd(struct wilco_ec_device *ec, u8 sub_cmd, u8 *out_val)
*/
static int h1_gpio_get(void *arg, u64 *val)
{
- return send_ec_cmd(arg, SUB_CMD_H1_GPIO, (u8 *)val);
+ int ret;
+
+ ret = send_ec_cmd(arg, SUB_CMD_H1_GPIO, (u8 *)val);
+ if (ret == 0)
+ *val &= 0xFF;
+ return ret;
}
DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02llx\n");
--
2.17.1
next prev parent reply other threads:[~2020-04-02 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 23:27 [PATCH] " Bernardo Perez Priego
2020-03-17 7:09 ` Enric Balletbo i Serra
2020-03-23 20:06 ` Daniel Campello
2020-03-24 13:54 ` Enric Balletbo i Serra
2020-03-27 17:24 ` Enric Balletbo i Serra
2020-04-02 22:33 ` Bernardo Perez Priego [this message]
2020-04-14 13:14 ` [PATCH v2] " Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402223331.28300-1-bernardo.perez.priego@intel.com \
--to=bernardo.perez.priego@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bleung@chromium.org \
--cc=campello@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®