mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Qian Cai <cai@lca.pw>, Prateek Sood <prsood@codeaurora.org>,
	Li Zefan <lizefan@huawei.com>,
	cgroups@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: Deadlock due to "cpuset: Make cpuset hotplug synchronous"
Date: Fri, 3 Apr 2020 10:55:23 -0400	[thread overview]
Message-ID: <20200403145523.GC162390@mtj.duckdns.org> (raw)
In-Reply-To: <20200326101529.xh763j5frq2r7mqv@e107158-lin>

On Thu, Mar 26, 2020 at 10:15:32AM +0000, Qais Yousef wrote:
> On 03/25/20 15:19, Tejun Heo wrote:
> > On Wed, Mar 25, 2020 at 03:16:56PM -0400, Qian Cai wrote:
> > > The linux-next commit a49e4629b5ed (“cpuset: Make cpuset hotplug synchronous”)
> > > introduced real deadlocks with CPU hotplug as showed in the lockdep splat, since it is
> > > now making a relation from cpu_hotplug_lock —> cgroup_mutex.
> > 
> > Prateek, can you please take a look? Given that the merge window is just around
> > the corner, we might have to revert and retry later if it can't be resolved
> > quickly.
> 
> I've ran cpuset_hotplug and cpuhotplug LTP tests using next-20200325 but
> couldn't reproduce it.
> 
> Hopefully that can be fixed, but if you had to revert it, do you mind picking
> this instead to fix the LTP issue I encountered before?
> 
> 	https://lore.kernel.org/lkml/20200211141554.24181-1-qais.yousef@arm.com/

So, I'd rather not, for now anyway. It isn't a real problem and I don't wanna
add a wait vector there.

Thanks.

-- 
tejun

  reply	other threads:[~2020-04-03 14:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 19:16 Qian Cai
2020-03-25 19:19 ` Tejun Heo
2020-03-26 10:15   ` Qais Yousef
2020-04-03 14:55     ` Tejun Heo [this message]
2020-04-06 10:55       ` Qais Yousef
2020-04-06 14:34         ` Tejun Heo
2020-04-07 13:07           ` Qais Yousef
2020-04-07 13:35             ` Tejun Heo
2020-04-02  2:00   ` Qian Cai
2020-04-03 14:54     ` Tejun Heo
2020-03-25 20:20 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403145523.GC162390@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=cai@lca.pw \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=peterz@infradead.org \
    --cc=prsood@codeaurora.org \
    --cc=qais.yousef@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®