From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AADAC2BA19 for ; Mon, 6 Apr 2020 14:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F356123A1D for ; Mon, 6 Apr 2020 14:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586182088; bh=vhgy+ynRxUHpgkk7e+S8dG76pMVg1GKWZpZgWdztIoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Vq3fu4vtDQYJ5acQIil8bgb/Wx7awp2mfAdJ80pNBmnihwP0HAPW5Bc/LuISuMZ/l 1AC4EA1H43UvRS8xDJ1R1wxmtZxl4vep+YZa96SwCB5VmosA5hj6dBMT5B25Wi4dZR 9xKvws5AwIk/EN8wIHEH312LiJAX8dOeTBnL1M94= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728645AbgDFOIG (ORCPT ); Mon, 6 Apr 2020 10:08:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:35926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728546AbgDFOIG (ORCPT ); Mon, 6 Apr 2020 10:08:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65414238E1; Mon, 6 Apr 2020 14:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586182085; bh=vhgy+ynRxUHpgkk7e+S8dG76pMVg1GKWZpZgWdztIoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IYLzb8Nm+sRiuji67P8mULB1l3aELwXC6jX+mkA4tZKJUI33MBO8HYv729g4sdVBA oS5g0++iCERktqPGvNmlezEGY16tvAEQK0ejAt7ewaua1+cpQ2FB1ps3+Z6TAbYuJq keh2EWYEPHa/pO4Mln43DeJnnPNDxCZ80IlK/c6s= Date: Mon, 6 Apr 2020 16:08:03 +0200 From: Greg KH To: Wang Hai Cc: puranjay12@gmail.com, robsonde@gmail.com, zhengbin13@huawei.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8192e: remove set but not used variable 'tmpRegC' Message-ID: <20200406140803.GB26701@kroah.com> References: <1586262964-4582-1-git-send-email-wanghai38@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1586262964-4582-1-git-send-email-wanghai38@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2020 at 08:36:04AM -0400, Wang Hai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c: In function rtl92e_start_adapter: > drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:693:15: warning: variable ‘tmpRegC’ set but not used [-Wunused-but-set-variable] > > commit 94a799425eee ("rtl8192e: Split into two directories") > involved this, remove it. > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > index ddcd788..ff934ae 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > @@ -690,7 +690,7 @@ bool rtl92e_start_adapter(struct net_device *dev) > u8 tmpvalue; > u8 ICVersion, SwitchingRegulatorOutput; > bool bfirmwareok = true; > - u32 tmpRegA, tmpRegC, TempCCk; > + u32 tmpRegA, TempCCk; > int i = 0; > u32 retry_times = 0; > > @@ -889,8 +889,8 @@ bool rtl92e_start_adapter(struct net_device *dev) > if (priv->IC_Cut >= IC_VersionCut_D) { > tmpRegA = rtl92e_get_bb_reg(dev, rOFDM0_XATxIQImbalance, > bMaskDWord); > - tmpRegC = rtl92e_get_bb_reg(dev, rOFDM0_XCTxIQImbalance, > - bMaskDWord); > + rtl92e_get_bb_reg(dev, rOFDM0_XCTxIQImbalance, > + bMaskDWord); That is odd, are you sure you aren't supposed to do something with that value you read? thanks, greg k-h