From: Guenter Roeck <linux@roeck-us.net>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 04/17] clk: mmp2: Add support for PLL clock sources
Date: Mon, 6 Apr 2020 12:30:50 -0700 [thread overview]
Message-ID: <20200406193050.GA53133@roeck-us.net> (raw)
In-Reply-To: <20200309194254.29009-5-lkundrak@v3.sk>
On Mon, Mar 09, 2020 at 08:42:41PM +0100, Lubomir Rintel wrote:
> The clk-of-mmp2 driver pretends that the clock outputs from the PLLs are
> constant, but in fact they are configurable.
>
> Add logic for obtaining the actual clock rates on MMP2 as well as MMP3.
> There is no documentation for either SoC, but the "systemsetting" drivers
> from Marvell GPL code dump provide some clue as far as MPMU registers on
> MMP2 [1] and MMP3 [2] go.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp3-dell-ariel.git/tree/drivers/char/mmp2_systemsetting.c
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp3-dell-ariel.git/tree/drivers/char/mmp3_systemsetting.c
>
> A separate commit will adjust the clk-of-mmp2 driver.
>
> Tested on a MMP3-based Dell Wyse 3020 as well as MMP2-based OLPC
> XO-1.75 laptop.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
This patch results in:
arm-linux-gnueabi-ld: drivers/clk/mmp/clk.o: in function `mmp_register_pll_clks':
drivers/clk/mmp/clk.c:192: undefined reference to `mmp_clk_register_pll'
when building arm:pxa910_defconfig.
Bisect log is attached.
Guenter
---
# bad: [a10c9c710f9ecea87b9f4bbb837467893b4bef01] Merge tag 'for-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply
# good: [4c205c84e249e0a91dcfabe461d77667ec9b2d05] Merge tag 'keys-fixes-20200329' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs
git bisect start 'a10c9c710f9e' '4c205c84e249'
# bad: [31c0aa87ec8a30b1e9e4cf862905a369560f7705] Merge tag 'random_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/random
git bisect bad 31c0aa87ec8a30b1e9e4cf862905a369560f7705
# bad: [53a2cc5cc36fd97728e1b418dbfa8f70bf23391a] Merge branches 'clk-ti', 'clk-ingenic', 'clk-typo', 'clk-at91', 'clk-mmp2' and 'clk-arm-icst' into clk-next
git bisect bad 53a2cc5cc36fd97728e1b418dbfa8f70bf23391a
# good: [2d11e9a1fd2abe784b334442b36f7d83ff914287] Merge branches 'clk-phase-errors', 'clk-amlogic', 'clk-renesas' and 'clk-allwinner' into clk-next
git bisect good 2d11e9a1fd2abe784b334442b36f7d83ff914287
# bad: [de17be999cb07effacf6a1129602f63396f5af27] clk: mmp2: Fix bit masks for LCDC I/O and pixel clocks
git bisect bad de17be999cb07effacf6a1129602f63396f5af27
# bad: [4d6da655d1871fadcb2b5de086e5a35883e22c95] dt-bindings: marvell,mmp2: Add clock ids for MMP3 PLLs
git bisect bad 4d6da655d1871fadcb2b5de086e5a35883e22c95
# bad: [5d34d0b32d6c13947b0aa890fc4c68f203491169] clk: mmp2: Add support for PLL clock sources
git bisect bad 5d34d0b32d6c13947b0aa890fc4c68f203491169
# good: [cb8dbfe831758fb2ba52d8c30db5249e48f57b8b] clk: mmp2: Constify some strings
git bisect good cb8dbfe831758fb2ba52d8c30db5249e48f57b8b
# good: [7de0b8b8b0508af5fed2f2a07e3abb6acac0c466] dt-bindings: clock: Convert marvell,mmp2-clock to json-schema
git bisect good 7de0b8b8b0508af5fed2f2a07e3abb6acac0c466
# first bad commit: [5d34d0b32d6c13947b0aa890fc4c68f203491169] clk: mmp2: Add support for PLL clock sources
next prev parent reply other threads:[~2020-04-06 19:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 19:42 [PATCH v2 00/17] clk: mmp2: MMP2 CLK Update Lubomir Rintel
2020-03-09 19:42 ` [PATCH v2 01/17] clk: mmp2: Remove a unused prototype Lubomir Rintel
2020-03-21 1:24 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 02/17] clk: mmp2: Constify some strings Lubomir Rintel
2020-03-21 1:24 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 03/17] dt-bindings: clock: Convert marvell,mmp2-clock to json-schema Lubomir Rintel
2020-03-21 1:24 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 04/17] clk: mmp2: Add support for PLL clock sources Lubomir Rintel
2020-03-21 1:24 ` Stephen Boyd
2020-04-06 19:30 ` Guenter Roeck [this message]
2020-04-09 8:32 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 05/17] clk: mmp2: Stop pretending PLL outputs are constant Lubomir Rintel
2020-03-21 1:24 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 06/17] dt-bindings: clock: Add MMP3 compatible string Lubomir Rintel
2020-03-21 1:24 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 07/17] clk: mmp2: Check for MMP3 Lubomir Rintel
2020-03-21 1:24 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 08/17] dt-bindings: marvell,mmp2: Add clock ids for MMP3 PLLs Lubomir Rintel
2020-03-21 1:24 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 09/17] clk: mmp2: Add PLLs that are available on MMP3 Lubomir Rintel
2020-03-21 1:25 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 10/17] ARM: dts: mmp3: Use the MMP3 compatible string for /clocks Lubomir Rintel
2020-03-21 1:20 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 11/17] dt-bindings: marvell,mmp2: Add clock ids for the GPU clocks Lubomir Rintel
2020-03-21 1:25 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 12/17] clk: mmp2: add " Lubomir Rintel
2020-03-21 1:25 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 13/17] dt-bindings: marvell,mmp2: Add clock ids for the thermal sensors Lubomir Rintel
2020-03-21 1:25 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 14/17] clk: mmp2: Add clocks " Lubomir Rintel
2020-03-21 1:25 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 15/17] dt-bindings: marvell,mmp2: Add clock id for the fifth SD HCI on MMP3 Lubomir Rintel
2020-03-21 1:25 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 16/17] clk: mmp2: Add clock for " Lubomir Rintel
2020-03-21 1:25 ` Stephen Boyd
2020-03-09 19:42 ` [PATCH v2 17/17] clk: mmp2: Fix bit masks for LCDC I/O and pixel clocks Lubomir Rintel
2020-03-21 1:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406193050.GA53133@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®