From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE698C2BA2B for ; Mon, 6 Apr 2020 21:13:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4413206B8 for ; Mon, 6 Apr 2020 21:13:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726312AbgDFVNK (ORCPT ); Mon, 6 Apr 2020 17:13:10 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:45032 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbgDFVNK (ORCPT ); Mon, 6 Apr 2020 17:13:10 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 403B91C47F0; Mon, 6 Apr 2020 23:13:08 +0200 (CEST) Date: Mon, 6 Apr 2020 23:13:07 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: Ricardo Ribalda Delgado , Dan Murphy , Linus Walleij , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: core: Fix warning message when init_data Message-ID: <20200406211307.GD12611@amd.ucw.cz> References: <20200401095147.444353-1-ribalda@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="P+33d92oIH25kiaB" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --P+33d92oIH25kiaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2020-04-01 21:49:00, Jacek Anaszewski wrote: > Hi Ricardo, >=20 > Thank you for the patch. >=20 > On 4/1/20 11:51 AM, Ricardo Ribalda Delgado wrote: > > The warning message when a led is renamed due to name collition can fail > > to show proper original name if init_data is used. Eg: > >=20 > > [ 9.073996] leds-gpio a0040000.leds_0: Led (null) renamed to red_led= _1 due to name collision > >=20 > > Fixes: bb4e9af0348d ("leds: core: Add support for composing LED class d= evice names") > > Signed-off-by: Ricardo Ribalda Delgado > > --- > > drivers/leds/led-class.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c > > index 1fc40e8af75e..3363a6551a70 100644 > > --- a/drivers/leds/led-class.c > > +++ b/drivers/leds/led-class.c > > @@ -376,7 +376,7 @@ int led_classdev_register_ext(struct device *parent, > > =20 > > if (ret) > > dev_warn(parent, "Led %s renamed to %s due to name collision", > > - led_cdev->name, dev_name(led_cdev->dev)); > > + proposed_name, dev_name(led_cdev->dev)); > > =20 > > if (led_cdev->flags & LED_BRIGHT_HW_CHANGED) { > > ret =3D led_add_brightness_hw_changed(led_cdev); > >=20 >=20 > Acked-by: Jacek Anaszewski Thanks, applied. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --P+33d92oIH25kiaB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXoubYwAKCRAw5/Bqldv6 8v9UAJwKQZAnZW36XiePXAyyOrCUgSLxCgCgnW6AbwGI7UI3O8EXyEB+c3tRsOA= =61Fb -----END PGP SIGNATURE----- --P+33d92oIH25kiaB--