From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA66C2BB55 for ; Tue, 7 Apr 2020 15:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E00220730 for ; Tue, 7 Apr 2020 15:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729439AbgDGPj5 (ORCPT ); Tue, 7 Apr 2020 11:39:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:57214 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728917AbgDGPj5 (ORCPT ); Tue, 7 Apr 2020 11:39:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 522E0ADDD; Tue, 7 Apr 2020 15:39:55 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 828541E1233; Tue, 7 Apr 2020 17:39:55 +0200 (CEST) Date: Tue, 7 Apr 2020 17:39:55 +0200 From: Jan Kara To: Thomas Gleixner Cc: Jan Kara , Andrei Vagin , LKML , stable@vger.kernel.org Subject: Re: [PATCH] ucount: Fix wrong inotify ucounts in /proc/sys/user Message-ID: <20200407153955.GH9482@quack2.suse.cz> References: <20200407121814.26073-1-jack@suse.cz> <87o8s3jskc.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o8s3jskc.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 07-04-20 16:09:39, Thomas Gleixner wrote: > Jan Kara writes: > > Commit 769071ac9f20 "ns: Introduce Time Namespace" broke reporting of > > inotify ucounts (max_inotify_instances, max_inotify_watches) in > > /proc/sys/user because it has added UCOUNT_TIME_NAMESPACES into enum > > ucount_type but didn't properly update reporting in > > kernel/ucount.c:setup_userns_sysctls(). Update the reporting to fix the > > issue and also add BUILD_BUG_ON to catch a similar problem in the > > future. > > Just merged that: > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=timers/urgent&id=eeec26d5da8248ea4e240b8795bb4364213d3247 > > Could you please send a patch with just the build bug on ? Sure, will do. Honza -- Jan Kara SUSE Labs, CR