From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B8AC2D0EA for ; Wed, 8 Apr 2020 16:08:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B24D6206F5 for ; Wed, 8 Apr 2020 16:08:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MgwmrRdg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730155AbgDHQIT (ORCPT ); Wed, 8 Apr 2020 12:08:19 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33072 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729684AbgDHQIT (ORCPT ); Wed, 8 Apr 2020 12:08:19 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D52D2522; Wed, 8 Apr 2020 18:08:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586362097; bh=AJzfCUM1HjeczLj5Whnp3MrdeZwLtEyNuz8qCxUuqww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MgwmrRdgrr9cVDRNCd23nmAvQGIUJgYrfc0CpnOKiNwMZKu8bCzBTX/A/K/rSyvfh +DR/f48BgmMyzWwKDuGlFi/nP/3kXKHtaCXhFiz8vFIL2oP0xbNpCWDwNEnRoluhRM +Zw2ycYZWgIbFN9H8VF4O6Fb/MV4OkIpGGq+GssA= Date: Wed, 8 Apr 2020 19:08:06 +0300 From: Laurent Pinchart To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Helen Koike , Jacob Chen , Shunqian Zheng , Yichong Zhong , Jacob Chen , Eddie Cai , Jeffy Chen , Allon Huang , Tomasz Figa , Ezequiel Garcia , Hans Verkuil , Mauro Carvalho Chehab , Greg Kroah-Hartman , Heiko Stuebner , Dafna Hirschfeld , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: staging: rkisp1: avoid unused variable warning Message-ID: <20200408160806.GJ4881@pendragon.ideasonboard.com> References: <20200408155325.2077345-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200408155325.2077345-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Thank you for the patch. On Wed, Apr 08, 2020 at 05:52:44PM +0200, Arnd Bergmann wrote: > When compile-testing with CONFIG_OF disabled, we get a warning > about an unused variable, and about inconsistent Kconfig dependencies: > > WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0 > Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=m] && (ARCH_ROCKCHIP [=n] || COMPILE_TEST [=y]) && OF [=n] > Selected by [m]: > - VIDEO_ROCKCHIP_ISP1 [=m] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=m] && VIDEO_V4L2 [=m] && VIDEO_V4L2_SUBDEV_API [=y] && (ARCH_ROCKCHIP [=n] || COMPILE_TEST [=y]) > > drivers/staging/media/rkisp1/rkisp1-dev.c: In function 'rkisp1_probe': > drivers/staging/media/rkisp1/rkisp1-dev.c:457:22: error: unused variable 'node' [-Werror=unused-variable] > 457 | struct device_node *node = pdev->dev.of_node; > > Simply open-coding the pointer dereference in the only place > the variable is used avoids the warning in all configurations, > so we can allow compile-testing as well. > > Fixes: d65dd85281fb ("media: staging: rkisp1: add Rockchip ISP1 base driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart > --- > drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig | 2 +- > drivers/staging/media/rkisp1/rkisp1-dev.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > index bd0147624de1..dd5d4d741bdd 100644 > --- a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > +++ b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > @@ -2,7 +2,7 @@ > > config PHY_ROCKCHIP_DPHY_RX0 > tristate "Rockchip MIPI Synopsys DPHY RX0 driver" > - depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > + depends on (ARCH_ROCKCHIP && OF) || COMPILE_TEST > select GENERIC_PHY_MIPI_DPHY > select GENERIC_PHY > help > diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c > index b1b3c058e957..5e7e797aad71 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-dev.c > +++ b/drivers/staging/media/rkisp1/rkisp1-dev.c > @@ -454,7 +454,6 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1) > > static int rkisp1_probe(struct platform_device *pdev) > { > - struct device_node *node = pdev->dev.of_node; > const struct rkisp1_match_data *clk_data; > const struct of_device_id *match; > struct device *dev = &pdev->dev; > @@ -463,7 +462,7 @@ static int rkisp1_probe(struct platform_device *pdev) > unsigned int i; > int ret, irq; > > - match = of_match_node(rkisp1_of_match, node); > + match = of_match_node(rkisp1_of_match, pdev->dev.of_node); > rkisp1 = devm_kzalloc(dev, sizeof(*rkisp1), GFP_KERNEL); > if (!rkisp1) > return -ENOMEM; -- Regards, Laurent Pinchart