From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED31C2BB86 for ; Thu, 9 Apr 2020 14:33:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 603B52078E for ; Thu, 9 Apr 2020 14:33:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="yegRnYyS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727737AbgDIOdC (ORCPT ); Thu, 9 Apr 2020 10:33:02 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56634 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbgDIOdC (ORCPT ); Thu, 9 Apr 2020 10:33:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=t108aSZwNrLLBTSbxD8GRa59ihUeOfYwdyM3oFc/ymk=; b=yegRnYyS0d6o7FbYu4mfEk7ndZ iDEx32RSJY5N+n8TtYqGlRN7WkPP+mAX7DIwPl+nJFE52m+xtOchIwo0CIzlQ/RmS5UVlD39ynfBQ UGa4HGYpMu2HG5t0Rt0CrY0dDDZA5IRTtYF1SpVbWuUZuUJd0hPXZXPu29igqxPcix5Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jMYEV-001omz-2C; Thu, 09 Apr 2020 16:32:43 +0200 Date: Thu, 9 Apr 2020 16:32:43 +0200 From: Andrew Lunn To: Pawel Dembicki Cc: Rob Herring , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Sam Ravnborg , Maxime Ripard , Heiko Stuebner , Linus Walleij , Stephan Gerhold , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Check Point L-50 board Message-ID: <20200409143243.GK389953@lunn.ch> References: <20200409070448.3209-1-paweldembicki@gmail.com> <20200409070448.3209-2-paweldembicki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409070448.3209-2-paweldembicki@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2020 at 09:04:44AM +0200, Pawel Dembicki wrote: > This patch adds dts for the Check Point L-50 from 600/1100 series > routers. Hi Pawel Looks very good. Just a minor comment: > +ð1 { > + status = "okay"; > + ethernet1-port@0 { > + speed = <1000>; > + duplex = <1>; > + }; > +}; This is a non-standard way of doing a fixed link. But looking at the driver, that is all it supports. I also don't think it is worth the effort converting it. Kirkwood is so old we hardly see any new boards using it. So: Reviewed-by: Andrew Lunn Since we are in the merge window at the moment, this won't be merged for a while. Andrew