mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: agross@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: qcom_rpm: remove defined but not used 'pm8921_ftsmps'
Date: Thu, 9 Apr 2020 18:29:19 -0700	[thread overview]
Message-ID: <20200410012919.GW20625@builder.lan> (raw)
In-Reply-To: <20200409114026.38383-1-yanaijie@huawei.com>

On Thu 09 Apr 04:40 PDT 2020, Jason Yan wrote:

> Fix the following gcc warning:
> 
> drivers/regulator/qcom_rpm-regulator.c:607:34: warning: ‘pm8921_ftsmps’
> defined but not used [-Wunused-const-variable=]
>  static const struct qcom_rpm_reg pm8921_ftsmps = {
>                                   ^~~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
>  drivers/regulator/qcom_rpm-regulator.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
> index 7fc97f23fcf4..1ee8ec686ed3 100644
> --- a/drivers/regulator/qcom_rpm-regulator.c
> +++ b/drivers/regulator/qcom_rpm-regulator.c
> @@ -604,16 +604,6 @@ static const struct qcom_rpm_reg pm8921_smps = {
>  	.supports_force_mode_bypass = false,
>  };
>  
> -static const struct qcom_rpm_reg pm8921_ftsmps = {
> -	.desc.linear_ranges = ftsmps_ranges,
> -	.desc.n_linear_ranges = ARRAY_SIZE(ftsmps_ranges),
> -	.desc.n_voltages = 101,
> -	.desc.ops = &uV_ops,
> -	.parts = &rpm8960_smps_parts,
> -	.supports_force_mode_auto = true,
> -	.supports_force_mode_bypass = false,
> -};
> -
>  static const struct qcom_rpm_reg pm8921_ncp = {
>  	.desc.linear_ranges = ncp_ranges,
>  	.desc.n_linear_ranges = ARRAY_SIZE(ncp_ranges),
> -- 
> 2.17.2
> 

  reply	other threads:[~2020-04-10  1:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 11:40 Jason Yan
2020-04-10  1:29 ` Bjorn Andersson [this message]
2020-04-14 15:58 ` Applied "regulator: qcom_rpm: remove defined but not used 'pm8921_ftsmps'" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200410012919.GW20625@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome