From: David Sterba <dsterba@suse.cz>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
David Sterba <dsterba@suse.com>,
Nikolay Borisov <nborisov@suse.com>,
Josef Bacik <josef@toxicpanda.com>, Chris Mason <clm@fb.com>,
"Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH] btrfs: re-instantiate the removed BTRFS_SUBVOL_CREATE_ASYNC definition
Date: Fri, 10 Apr 2020 18:45:33 +0200 [thread overview]
Message-ID: <20200410164533.GP5920@twin.jikos.cz> (raw)
In-Reply-To: <20200401032650.GA24378@asgard.redhat.com>
On Wed, Apr 01, 2020 at 05:26:50AM +0200, Eugene Syromiatnikov wrote:
> The commit 9c1036fdb1d1ff1b ("btrfs: Remove BTRFS_SUBVOL_CREATE_ASYNC
> support") breaks strace build with the kernel headers from git:
>
> btrfs.c: In function "btrfs_test_subvol_ioctls":
> btrfs.c:531:23: error: "BTRFS_SUBVOL_CREATE_ASYNC" undeclared (first use
> in this function)
> vol_args_v2.flags = BTRFS_SUBVOL_CREATE_ASYNC;
>
> Moreover, it is improper to break UAPI anyway.
IIRC the reason for the UAPI exports was to let strace use the includes
to decode the ioctls, so for that I agree it's improper to break the
build, sorry. The ioctls are a public interface so it's an ABI. Patch
added to 5.7 queue, thanks.
prev parent reply other threads:[~2020-04-10 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 3:26 Eugene Syromiatnikov
2020-04-01 6:47 ` Nikolay Borisov
2020-04-10 16:45 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410164533.GP5920@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=esyr@redhat.com \
--cc=josef@toxicpanda.com \
--cc=ldv@altlinux.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®