From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rui.zhang@intel.com
Cc: amit.kucheria@verdurent.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org (open list:THERMAL)
Subject: [PATCH 4/6] thermal: power_allocator: Remove useless test
Date: Sat, 11 Apr 2020 00:12:33 +0200 [thread overview]
Message-ID: <20200410221236.6484-5-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20200410221236.6484-1-daniel.lezcano@linaro.org>
The function power_actor_set_power() does check if the specified
cooling device is a power actor.
Call the function and handle the return code like what do the other
calls to power_actor_* functions.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/power_allocator.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/thermal/power_allocator.c b/drivers/thermal/power_allocator.c
index f8e4219cf5de..fd7c8de02250 100644
--- a/drivers/thermal/power_allocator.c
+++ b/drivers/thermal/power_allocator.c
@@ -427,11 +427,10 @@ static int allocate_power(struct thermal_zone_device *tz,
if (instance->trip != trip_max_desired_temperature)
continue;
- if (!cdev_is_power_actor(instance->cdev))
+ if (power_actor_set_power(instance->cdev, instance,
+ granted_power[i]))
continue;
- power_actor_set_power(instance->cdev, instance,
- granted_power[i]);
total_granted_power += granted_power[i];
i++;
--
2.17.1
next prev parent reply other threads:[~2020-04-10 22:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 22:12 [PATCH 0/6] Consolidate the thermal_cdev_update() function Daniel Lezcano
2020-04-10 22:12 ` [PATCH 1/6] thermal: hwmon: Replace the call the thermal_cdev_update() Daniel Lezcano
2020-04-11 1:32 ` Guenter Roeck
2020-04-11 16:45 ` Daniel Lezcano
2020-04-11 17:26 ` Guenter Roeck
2020-04-11 21:07 ` Daniel Lezcano
2020-04-10 22:12 ` [PATCH 2/6] thermal: core: Move thermal_cdev_update next to updated=false Daniel Lezcano
2020-04-10 22:12 ` [PATCH 3/6] thermal: core: Remove pointless 'updated' boolean Daniel Lezcano
2020-04-10 22:12 ` Daniel Lezcano [this message]
2020-04-10 22:12 ` [PATCH 5/6] thermal: core: Move the call to thermal_cdev_udpate() to the power allocator Daniel Lezcano
2020-04-10 22:12 ` [PATCH 6/6] thermal: core: Make thermal_cdev_update private Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410221236.6484-5-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome