From: Dave Chinner <david@fromorbit.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: linux-fsdevel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org,
Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
Subject: Re: [PATCH] ovl: skip overlayfs superblocks at global sync
Date: Sun, 12 Apr 2020 08:28:29 +1000 [thread overview]
Message-ID: <20200411222829.GO10737@dread.disaster.area> (raw)
In-Reply-To: <158642098777.5635.10501704178160375549.stgit@buzz>
On Thu, Apr 09, 2020 at 11:29:47AM +0300, Konstantin Khlebnikov wrote:
> Stacked filesystems like overlayfs has no own writeback, but they have to
> forward syncfs() requests to backend for keeping data integrity.
>
> During global sync() each overlayfs instance calls method ->sync_fs()
> for backend although it itself is in global list of superblocks too.
> As a result one syscall sync() could write one superblock several times
> and send multiple disk barriers.
>
> This patch adds flag SB_I_SKIP_SYNC into sb->sb_iflags to avoid that.
Why wouldn't you just remove the ->sync_fs method from overlay?
I mean, if you don't need the filesystem to do anything special for
one specific data integrity sync_fs call, you don't need it for any
of them, yes?
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-04-11 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 8:29 Konstantin Khlebnikov
2020-04-09 10:23 ` Amir Goldstein
2020-04-09 11:28 ` Konstantin Khlebnikov
2020-04-09 11:48 ` Amir Goldstein
2020-04-09 12:04 ` Konstantin Khlebnikov
2020-04-09 13:22 ` Amir Goldstein
2020-04-11 22:28 ` Dave Chinner [this message]
2020-04-12 6:46 ` Amir Goldstein
2020-04-21 9:36 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411222829.GO10737@dread.disaster.area \
--to=david@fromorbit.com \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®