From: Greg KH <gregkh@linuxfoundation.org>
To: carlosteniswarrior@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: jr3_pci: fixed two warnings
Date: Mon, 13 Apr 2020 14:54:37 +0200 [thread overview]
Message-ID: <20200413125437.GA3116954@kroah.com> (raw)
In-Reply-To: <20200412142508.327-1-carlosteniswarrior@gmail.com>
On Sun, Apr 12, 2020 at 04:25:08PM +0200, carlosteniswarrior@gmail.com wrote:
> Fixed two checkpatch warnings.
>
> Signed-off-by: Carlos Guerrero Alvarez <carlosteniswarrior@gmail.com>
> ---
> drivers/staging/comedi/drivers/jr3_pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
> index c3c88e6d298f..6bc87d3c6c3b 100644
> --- a/drivers/staging/comedi/drivers/jr3_pci.c
> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> @@ -91,8 +91,8 @@ struct jr3_pci_dev_private {
> };
>
> union jr3_pci_single_range {
> - struct comedi_lrange l;
> - char _reserved[offsetof(struct comedi_lrange, range[1])];
> + const comedi_lrange l;
> + char _reserved[offsetof(const comedi_lrange, range[1])];
> };
Please work on your knowledge of C first, before modifying Linux kernel
code. Mistakes like this show you need a bit more work there first.
Good luck!
greg k-h
prev parent reply other threads:[~2020-04-13 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 14:25 carlosteniswarrior
2020-04-12 16:56 ` Joe Perches
2020-04-12 17:18 ` kbuild test robot
2020-04-13 12:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413125437.GA3116954@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=carlosteniswarrior@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome