From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B756C2BA19 for ; Tue, 14 Apr 2020 13:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10C3320644 for ; Tue, 14 Apr 2020 13:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732656AbgDNNln (ORCPT ); Tue, 14 Apr 2020 09:41:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:53142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732577AbgDNNl0 (ORCPT ); Tue, 14 Apr 2020 09:41:26 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 764172075E; Tue, 14 Apr 2020 13:41:23 +0000 (UTC) Date: Tue, 14 Apr 2020 09:41:21 -0400 From: Steven Rostedt To: Julien Thierry Cc: Matt Helsley , linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , Ingo Molnar , Miroslav Benes Subject: Re: [RFC][PATCH 03/36] objtool: Enable compilation of objtool for all architectures Message-ID: <20200414094121.73f5c82a@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Apr 2020 08:39:23 +0100 Julien Thierry wrote: > My concern with this it that most of the structures and code in arch.h > and check.c can/should be reused across architectures. So, when > providing support for a new architecutre, the first thing that will be > needed is to move those back under tools/objtool whithout disturbing the > arches that don't yet provide support for "check" subcommand. Are all the enums and structs in arch.h non-arch specific? Or would they need to be split? > > So, if it is decided that recordmcount should be an objtool subcommand, > the code itself should probably stay under tools/objtool and then have > different compilation configurations for objtool depending on the > architecture (e.g. HAVE_OBJTOOL_CHECK, HAVE_OBJTOOL_ORC) or something of > the sort. That could work. -- Steve