From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peng Wang <rocking@linux.alibaba.com>,
Ingo Molnar <mingo@redhat.com>,
uri.lelli@redhat.com, Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: Simplify the code of should_we_balance()
Date: Tue, 14 Apr 2020 12:57:23 +0200 [thread overview]
Message-ID: <20200414105723.GN20713@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtBLc7Y-a-nuXF-p8wEaJQLiQn4crOg6R0Z4NBJ64yMLBg@mail.gmail.com>
On Tue, Apr 14, 2020 at 09:25:00AM +0200, Vincent Guittot wrote:
> On Sat, 11 Apr 2020 at 11:21, Peng Wang <rocking@linux.alibaba.com> wrote:
> >
> > We only consider group_balance_cpu() after there is no idle
> > cpu. So, just do comparison before return at these two cases.
> >
> > Signed-off-by: Peng Wang <rocking@linux.alibaba.com>
>
> With the small fix in the comment below
Done
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Thanks Guys!
next prev parent reply other threads:[~2020-04-14 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 9:20 Peng Wang
2020-04-12 8:42 ` Peng Wang
2020-04-13 20:32 ` Valentin Schneider
2020-04-14 7:25 ` Vincent Guittot
2020-04-14 10:57 ` Peter Zijlstra [this message]
2020-04-14 8:48 ` [PATCH v2] " Peng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414105723.GN20713@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rocking@linux.alibaba.com \
--cc=rostedt@goodmis.org \
--cc=uri.lelli@redhat.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®