From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B522C3815B for ; Tue, 14 Apr 2020 15:20:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2045206D5 for ; Tue, 14 Apr 2020 15:20:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407433AbgDNPUr (ORCPT ); Tue, 14 Apr 2020 11:20:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:46424 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438742AbgDNPUN (ORCPT ); Tue, 14 Apr 2020 11:20:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 73C92AC26; Tue, 14 Apr 2020 15:20:10 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 83F15DA823; Tue, 14 Apr 2020 17:19:31 +0200 (CEST) Date: Tue, 14 Apr 2020 17:19:31 +0200 From: David Sterba To: Tang Bin Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Shengju Zhang Subject: Re: [PATCH] btrfs: Fix backref.c selftest compilation warning Message-ID: <20200414151931.GU5920@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Tang Bin , clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Shengju Zhang References: <20200411154915.9408-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200411154915.9408-1-tangbin@cmss.chinamobile.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 11, 2020 at 11:49:15PM +0800, Tang Bin wrote: > Fix missing braces compilation warning in the ARM > compiler environment: > fs/btrfs/backref.c: In function ‘is_shared_data_backref’: > fs/btrfs/backref.c:394:9: warning: missing braces around initializer [-Wmissing-braces] > struct prelim_ref target = {0}; > fs/btrfs/backref.c:394:9: warning: (near initialization for ‘target.rbnode’) [-Wmissing-braces] > > Signed-off-by: Tang Bin > Signed-off-by: Shengju Zhang > --- > fs/btrfs/backref.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c > index 9c380e7..0cc0257 100644 > --- a/fs/btrfs/backref.c > +++ b/fs/btrfs/backref.c > @@ -391,7 +391,7 @@ static int is_shared_data_backref(struct preftrees *preftrees, u64 bytenr) > struct rb_node **p = &preftrees->direct.root.rb_root.rb_node; > struct rb_node *parent = NULL; > struct prelim_ref *ref = NULL; > - struct prelim_ref target = {0}; > + struct prelim_ref target = {}; I wonder why this initialization is a problem while there are about 20 other uses of "{0}". The warning is about the embedded rbnode, but why does a more recent compiler not warn about that? Is this a missing fix from the one you use? I don't mind fixing compiler warnings as long as it bothers enough people, eg. we have fixes reported by gcc 7 but I'm hesitant to fix anything older without a good reason.