From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A4CC2BA19 for ; Tue, 14 Apr 2020 16:03:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3DBE2076B for ; Tue, 14 Apr 2020 16:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JVEiqEpI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391233AbgDNQDc (ORCPT ); Tue, 14 Apr 2020 12:03:32 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:24386 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728154AbgDNQDO (ORCPT ); Tue, 14 Apr 2020 12:03:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586880193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0DRJu6S7NO8P/54MkunY2BJyUaaOoGwDBAo8xy+uwXA=; b=JVEiqEpIRffp2YZqTbkoEXm7Eo3d9CvFrhtNOVjsJRleIhB/NSbuOBG8XWhN3jeAKCZMLH uqh6E7hljIqLpxurmgCE6kRFDK7Z9+gtNDK4mDZHkVtGKB+AZ/KvZaYE2VDC+gERTy4EmA +dJvWNhajO+WuHlwd8z8q/qdYNgAQ4k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-44-0I89OzOXOGWoHGikds0Gjw-1; Tue, 14 Apr 2020 12:03:11 -0400 X-MC-Unique: 0I89OzOXOGWoHGikds0Gjw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2CECC801FA1; Tue, 14 Apr 2020 16:03:10 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.194.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A365B99DFD; Tue, 14 Apr 2020 16:02:58 +0000 (UTC) Date: Tue, 14 Apr 2020 18:02:55 +0200 From: Andrew Jones To: Sean Christopherson Cc: Paolo Bonzini , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Xu , Wainer dos Santos Moschetta Subject: Re: [PATCH 01/10] KVM: selftests: Take vcpu pointer instead of id in vm_vcpu_rm() Message-ID: <20200414160255.b7ftigb3mdfbcmjk@kamzik.brq.redhat.com> References: <20200410231707.7128-1-sean.j.christopherson@intel.com> <20200410231707.7128-2-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200410231707.7128-2-sean.j.christopherson@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 10, 2020 at 04:16:58PM -0700, Sean Christopherson wrote: > The sole caller of vm_vcpu_rm() already has the vcpu pointer, take it > directly instead of doing an extra lookup. > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/lib/kvm_util.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 8a3523d4434f..9a783c20dd26 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -393,7 +393,7 @@ struct vcpu *vcpu_find(struct kvm_vm *vm, uint32_t vcpuid) > * > * Input Args: > * vm - Virtual Machine > - * vcpuid - VCPU ID > + * vcpu - VCPU to remove > * > * Output Args: None > * > @@ -401,9 +401,8 @@ struct vcpu *vcpu_find(struct kvm_vm *vm, uint32_t vcpuid) > * > * Within the VM specified by vm, removes the VCPU given by vcpuid. > */ > -static void vm_vcpu_rm(struct kvm_vm *vm, uint32_t vcpuid) > +static void vm_vcpu_rm(struct kvm_vm *vm, struct vcpu *vcpu) > { > - struct vcpu *vcpu = vcpu_find(vm, vcpuid); > int ret; > > ret = munmap(vcpu->state, sizeof(*vcpu->state)); > @@ -427,7 +426,7 @@ void kvm_vm_release(struct kvm_vm *vmp) > int ret; > > while (vmp->vcpu_head) > - vm_vcpu_rm(vmp, vmp->vcpu_head->id); > + vm_vcpu_rm(vmp, vmp->vcpu_head); > > ret = close(vmp->fd); > TEST_ASSERT(ret == 0, "Close of vm fd failed,\n" > -- > 2.26.0 > Reviewed-by: Andrew Jones