From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 756DAC2BA19 for ; Tue, 14 Apr 2020 16:04:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5757A20775 for ; Tue, 14 Apr 2020 16:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391275AbgDNQEx (ORCPT ); Tue, 14 Apr 2020 12:04:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:44278 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391244AbgDNQDw (ORCPT ); Tue, 14 Apr 2020 12:03:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3706CAC77; Tue, 14 Apr 2020 16:03:50 +0000 (UTC) Date: Tue, 14 Apr 2020 18:03:50 +0200 From: Borislav Petkov To: Leon Romanovsky Cc: "David S . Miller" , Jakub Kicinski , Leon Romanovsky , Jessica Yu , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use Message-ID: <20200414160349.GH31763@zn.tnic> References: <20200414155732.1236944-1-leon@kernel.org> <20200414155732.1236944-5-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200414155732.1236944-5-leon@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 06:57:32PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > VERMAGIC* definitions are not supposed to be used by the drivers, Yeah, this was only me conjecturing here. But yes, if people agree, this would be one way to do it. In any case and FWIW, series looks ok to me: Acked-by: Borislav Petkov Thx. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg