From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 378DEC2BB85 for ; Tue, 14 Apr 2020 18:27:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B4382076C for ; Tue, 14 Apr 2020 18:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586888832; bh=hFNLUX5d/6VjCP7/nuZYKMX4WhCYb5wTCkL0pjVz/cc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SpLLlwJf6r7TWgd0m2hu3ZQFqNpcUtE/o8ioc3adVQZ/lMJAg46qTEJvbR/xpZzCu 30TohBK+ncalzFvm5YTSCd0Alj/sWhXTfJfyGKhOf2FVJxklJTrOitCpFBFjsMnTms j/XtNiTEf/ox+C4inFy7Y7a+Z1B4sg0tLlShwmd4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503929AbgDNS1I (ORCPT ); Tue, 14 Apr 2020 14:27:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:38434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729695AbgDNS1D (ORCPT ); Tue, 14 Apr 2020 14:27:03 -0400 Received: from Mani-XPS-13-9360 (unknown [157.50.36.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 695D420575; Tue, 14 Apr 2020 18:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586888822; bh=hFNLUX5d/6VjCP7/nuZYKMX4WhCYb5wTCkL0pjVz/cc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XfkRvFH+I62D7vY0osPBoSlwtLFj+YlTQoGNl+0cFfI0eT8RGcsAOzn9YFaFgBr30 yYmRl17e3QJGZhIT+P46p+34M/AZjL9kgNbvoIAPXaroKE/5s9lvflOytQJkBEaLHD z/MAq1RwZ2lakZ8V3g78Ch4POz83wHQ77jekgUKU= Date: Tue, 14 Apr 2020 23:56:52 +0530 From: Manivannan Sadhasivam To: Jonathan Cameron Cc: Andy Shevchenko , Rob Herring , narcisaanamaria12@gmail.com, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , linux-iio , devicetree , Linux Kernel Mailing List Subject: Re: [PATCH v2 2/3] iio: chemical: Add support for external Reset and Wakeup in CCS811 Message-ID: <20200414182652.GA29921@Mani-XPS-13-9360> References: <20200414153415.957-1-mani@kernel.org> <20200414153415.957-3-mani@kernel.org> <20200414170547.GB3334@Mani-XPS-13-9360> <20200414191259.5fbfdc2a@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414191259.5fbfdc2a@archlinux> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 07:12:59PM +0100, Jonathan Cameron wrote: > On Tue, 14 Apr 2020 20:54:49 +0300 > Andy Shevchenko wrote: > > > On Tue, Apr 14, 2020 at 8:06 PM Manivannan Sadhasivam wrote: > > > On Tue, Apr 14, 2020 at 07:42:24PM +0300, Andy Shevchenko wrote: > > > > On Tue, Apr 14, 2020 at 6:34 PM wrote: > > > > ... > > > > > > > + reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", > > > > > + GPIOD_OUT_LOW); > > > > > + if (IS_ERR(reset_gpio)) { > > > > > > > > > + dev_err(&client->dev, "Failed to acquire reset gpio\n"); > > > > > > > > If it's a deferred probe, it would spam the log. > > > > > > > > > > Hmm. But error is an error isn't it? Would you recommend doing a debug print > > > or completely removing the logging? > > > > I would remove completely, but better to wait for Jonathan to comment. > > Maybe he prefers something like > > if (err != EPROBE_DEFER) > > dev_err() > > Not fussed. Either drop it or do the check for defer - one I leave up to the > author. > Okay, will just drop it. Thanks, Mani > > > > > > > + return PTR_ERR(reset_gpio); > > > > > + } > > > > > > > > ... > > > > > > > > > + static const u8 reset_seq[] = { > > > > > + 0xFF, 0x11, 0xE5, 0x72, 0x8A, > > > > > + }; > > > > > > > > I would suggest to comment above from where you got this and the > > > > meaning of the numbers. > > > > > > > > > > The datasheet doesn't specify the meaning of these values. But will add a > > > comment. > > > > Thanks! > > > > > Btw, just noticed that 0xFF is not needed and only 4 values are > > > sufficient for SW reset. > > > > Better to do exactly what datasheet suggests (in case it's not clear > > or deductible what is going on). > > >