From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: peterz@infradead.org, mingo@kernel.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Remove redundant section name comparison
Date: Tue, 14 Apr 2020 17:33:57 -0500 [thread overview]
Message-ID: <20200414223357.tbc66fdok5nxb4if@treble> (raw)
In-Reply-To: <20200412144405.4423-1-songmuchun@bytedance.com>
On Sun, Apr 12, 2020 at 10:44:05PM +0800, Muchun Song wrote:
> If the prefix of section name is not '.rodata', the following
> function call can never return 0.
>
> strcmp(sec->name, C_JUMP_TABLE_SECTION)
>
> So the name comparison is pointless, just remove it.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Thanks, added to the queue.
--
Josh
prev parent reply other threads:[~2020-04-14 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 14:44 Muchun Song
2020-04-14 22:33 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414223357.tbc66fdok5nxb4if@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®