From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Petr Mladek <pmladek@suse.com>,
Andrey Zhizhikin <andrey.z@gmail.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kan Liang <kan.liang@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v5 0/3] perf synthetic events
Date: Tue, 14 Apr 2020 22:40:47 -0700 [thread overview]
Message-ID: <20200415054050.31645-1-irogers@google.com> (raw)
Add a multi-threaded version of the internals synthesize benchmark. It
attempts to compute a time per event synthesized, but as it is reading
/proc there are issues:
- permissions if not run as root
- "random" nature of /proc
By default the benchmark is disabled but can be enabled with a
flag. It has been useful in gauging the value of multi-threaded
improvements not included here as their value appears minimal.
The patch set includes 2 patches that improve synthesis performance
and updates the benchmark numbers:
https://lore.kernel.org/lkml/20200411064248.247530-1-irogers@google.com/
v4 added a missing test file
v3 improved documenation, return values and added testing to the io framework
following feedback from namhyung@kernel.org.
v2 addressed single threaded synthesize benchmark issues from jolsa@redhat.com
https://lore.kernel.org/lkml/20200402154357.107873-1-irogers@google.com/
Ian Rogers (3):
perf bench: add a multi-threaded synthesize benchmark
tools api: add a lightweight buffered reading api
perf synthetic events: Remove use of sscanf from /proc reading
tools/lib/api/io.h | 112 +++++++++++
tools/perf/bench/synthesize.c | 211 +++++++++++++++++---
tools/perf/tests/Build | 1 +
tools/perf/tests/api-io.c | 304 +++++++++++++++++++++++++++++
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/tests.h | 1 +
tools/perf/util/synthetic-events.c | 157 ++++++++++-----
7 files changed, 713 insertions(+), 77 deletions(-)
create mode 100644 tools/lib/api/io.h
create mode 100644 tools/perf/tests/api-io.c
--
2.26.0.110.g2183baf09c-goog
next reply other threads:[~2020-04-15 5:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 5:40 Ian Rogers [this message]
2020-04-15 5:40 ` [PATCH v5 1/3] perf bench: add a multi-threaded synthesize benchmark Ian Rogers
2020-04-23 14:17 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] perf bench: Add " tip-bot2 for Ian Rogers
2020-04-15 5:40 ` [PATCH v5 2/3] tools api: add a lightweight buffered reading api Ian Rogers
2020-05-08 13:05 ` [tip: perf/core] tools api: Add " tip-bot2 for Ian Rogers
2020-04-15 5:40 ` [PATCH v5 3/3] perf synthetic events: Remove use of sscanf from /proc reading Ian Rogers
2020-05-08 13:05 ` [tip: perf/core] " tip-bot2 for Ian Rogers
2020-04-16 14:19 ` [PATCH v5 0/3] perf synthetic events Namhyung Kim
2020-04-23 14:24 ` Arnaldo Carvalho de Melo
2020-04-24 7:42 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415054050.31645-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrey.z@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®