From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309A4C2BB1D for ; Wed, 15 Apr 2020 03:24:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D35320784 for ; Wed, 15 Apr 2020 03:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586921058; bh=wTVTBdIHEqCex23yW6xwI9OoQMcfzXT4+ioyVchFUpQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=KvwiKSz1mH3brQon2Jnqiihy8xVcD5IFpOAO8VGsXtHXYqOCa/VwrSgUJJ82AOtYu 5KJ2/stzk7OfKeztXbVzy9IFFwROEhD9Mi1kAfmYas8P6ooatMefuiWAiRw3tN3lB8 yCEZmczPfCmpeI8T9RJqbYXd/+/2ptXyv3v2uOUA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729815AbgDODYO (ORCPT ); Tue, 14 Apr 2020 23:24:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:38432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbgDODYG (ORCPT ); Tue, 14 Apr 2020 23:24:06 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A6FA72076C; Wed, 15 Apr 2020 03:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586921046; bh=wTVTBdIHEqCex23yW6xwI9OoQMcfzXT4+ioyVchFUpQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SfgtJRTcjPqkS72/m2sKOzvm1oR0MQnLje3I7RBxdagvdugW7f21nTRsWItsS62Om 4ua6aAcdc1lphqCNXdIWozTCflGDucinEtWwGZ75IfujdrkhsLsMIVb4xDpJfWp3dM eTGgBBUrs5bYS3IBK1IWiTLhp6ohQbxOCpdf5iG8= Date: Wed, 15 Apr 2020 12:23:59 +0900 From: Masami Hiramatsu To: Vlastimil Babka Cc: Andrew Morton , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner , Masami Hiramatsu Subject: Re: [PATCH v2 0/3] support setting sysctl parameters from kernel command line Message-Id: <20200415122359.939364e2c54c389c6b3f6457@kernel.org> In-Reply-To: <20200414113222.16959-1-vbabka@suse.cz> References: <20200414113222.16959-1-vbabka@suse.cz> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vlastimil, On Tue, 14 Apr 2020 13:32:19 +0200 Vlastimil Babka wrote: > This series adds support for something that seems like many people always > wanted but nobody added it yet, so here's the ability to set sysctl parameters > via kernel command line options in the form of sysctl.vm.something=1 Sounds good. And would you consider to use the bootconfig instead of (or in addition to) the kernel command line, because it is too short to describe the sysctl options? With the bootconfig, you can describe the sysctl parameters in an independent file as same as /etc/sysctl.conf. It is easy to convert form sysctl.conf to bootconfig because bootconfig format is simply enhanced structured sysctl.conf :). What we just need is; (echo "sysctl {"; cat "/etc/sysctl.conf"; echo "}") >> sysctl.bconf bootconfig -a sysctl.bconf /boot/initrd.img Even with only your patch, since bootconfig can pass the options which start with "kernel." prefix to kernel command line, so; (echo "kernel.sysctl {"; cat "/etc/sysctl.conf"; echo "}") >> sysctl.bconf bootconfig -a sysctl.bconf /boot/initrd.img should work. Thank you, -- Masami Hiramatsu