From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9347C2D0EF for ; Thu, 16 Apr 2020 05:22:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B16CD20771 for ; Thu, 16 Apr 2020 05:22:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406251AbgDPFWq (ORCPT ); Thu, 16 Apr 2020 01:22:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2405910AbgDPFWm (ORCPT ); Thu, 16 Apr 2020 01:22:42 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EA60C061A0C for ; Wed, 15 Apr 2020 22:22:42 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOwyv-0003eK-7t; Thu, 16 Apr 2020 07:22:33 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jOwyr-0007W6-OK; Thu, 16 Apr 2020 07:22:29 +0200 Date: Thu, 16 Apr 2020 07:22:29 +0200 From: Marco Felsch To: Anson Huang Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH 1/5] dt-bindings: clock: Convert i.MX6Q clock to json-schema Message-ID: <20200416052229.m6ur2coyfg6ef7vz@pengutronix.de> References: <1587011171-24532-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587011171-24532-1-git-send-email-Anson.Huang@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 07:12:42 up 152 days, 20:31, 155 users, load average: 0.08, 0.14, 0.08 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anson, thanks for the patch. I have two questions please see inline which applies to all patches. On 20-04-16 12:26, Anson Huang wrote: ... > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > new file mode 100644 > index 0000000..084d4f0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/imx6q-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Clock bindings for Freescale i.MX6 Quad > + > +maintainers: > + - Anson Huang > + > +properties: > + compatible: > + const: fsl,imx6q-ccm > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 Why 1 and not 2? The RM describes that the ccm has 2 interrupts. > + maxItems: 2 > + > + '#clock-cells': > + const: 1 > + > + clocks: > + items: > + - description: 24m osc > + - description: 32k osc > + - description: ckih1 clock input > + - description: anaclk1 clock input > + - description: anaclk2 clock input > + > + clock-names: > + items: > + - const: osc > + - const: ckil > + - const: ckih1 > + - const: anaclk1 > + - const: anaclk2 > + > + fsl,pmic-stby-poweroff: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + Use this property if the SoC should be powered off by external power > + management IC (PMIC) triggered via PMIC_STBY_REQ signal. > + Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should > + be using "syscon-poweroff" driver instead. > + > +required: > + - compatible > + - reg > + - interrupts > + - '#clock-cells' > + > +examples: > + # Clock Control Module node: > + - | > + #include > + > + clks: clock-controller@20c4000 { > + compatible = "fsl,imx6q-ccm"; > + reg = <0x020c4000 0x4000>; > + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>, > + <0 88 IRQ_TYPE_LEVEL_HIGH>; > + #clock-cells = <1>; > + }; > + > +... Why these '...' here? Regards, Marco > -- > 2.7.4