From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D4DC2D0EF for ; Thu, 16 Apr 2020 06:54:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A60F1214D8 for ; Thu, 16 Apr 2020 06:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437083AbgDPGyO (ORCPT ); Thu, 16 Apr 2020 02:54:14 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:41528 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437503AbgDPGxl (ORCPT ); Thu, 16 Apr 2020 02:53:41 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jOyOm-0005OM-En; Thu, 16 Apr 2020 16:53:21 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 16 Apr 2020 16:53:20 +1000 Date: Thu, 16 Apr 2020 16:53:20 +1000 From: Herbert Xu To: Arnd Bergmann Cc: Tom Lendacky , "David S. Miller" , Gary R Hook , Ard Biesheuvel , Thomas Gleixner , Greg Kroah-Hartman , Eric Biggers , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: ccp -- don't "select" CONFIG_DMADEVICES Message-ID: <20200416065320.GJ7901@gondor.apana.org.au> References: <20200408162652.3987688-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408162652.3987688-1-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2020 at 06:26:48PM +0200, Arnd Bergmann wrote: > DMADEVICES is the top-level option for the slave DMA > subsystem, and should not be selected by device drivers, > as this can cause circular dependencies such as: > > drivers/net/ethernet/freescale/Kconfig:6:error: recursive dependency detected! > drivers/net/ethernet/freescale/Kconfig:6: symbol NET_VENDOR_FREESCALE depends on PPC_BESTCOMM > drivers/dma/bestcomm/Kconfig:6: symbol PPC_BESTCOMM depends on DMADEVICES > drivers/dma/Kconfig:6: symbol DMADEVICES is selected by CRYPTO_DEV_SP_CCP > drivers/crypto/ccp/Kconfig:10: symbol CRYPTO_DEV_SP_CCP depends on CRYPTO > crypto/Kconfig:16: symbol CRYPTO is selected by LIBCRC32C > lib/Kconfig:222: symbol LIBCRC32C is selected by LIQUIDIO > drivers/net/ethernet/cavium/Kconfig:65: symbol LIQUIDIO depends on PTP_1588_CLOCK > drivers/ptp/Kconfig:8: symbol PTP_1588_CLOCK is implied by FEC > drivers/net/ethernet/freescale/Kconfig:23: symbol FEC depends on NET_VENDOR_FREESCALE > > The LIQUIDIO driver causing this problem is addressed in a > separate patch, but this change is needed to prevent it from > happening again. > > Using "depends on DMADEVICES" is what we do for all other > implementations of slave DMA controllers as well. > > Fixes: b3c2fee5d66b ("crypto: ccp - Ensure all dependencies are specified") > Signed-off-by: Arnd Bergmann > --- > drivers/crypto/ccp/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt