From: Daniel Vetter <daniel@ffwll.ch>
To: YueHaibing <yuehaibing@huawei.com>
Cc: patrik.r.jakobsson@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/gma500: remove unused variable 'hdmi_ids'
Date: Fri, 17 Apr 2020 17:24:14 +0200 [thread overview]
Message-ID: <20200417152414.GR3456981@phenom.ffwll.local> (raw)
In-Reply-To: <20200417101032.8140-1-yuehaibing@huawei.com>
On Fri, Apr 17, 2020 at 06:10:32PM +0800, YueHaibing wrote:
> drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=]
> static const struct pci_device_id hdmi_ids[] = {
> ^~~~~~~~
>
> It is never used, remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Queued for 5.8, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> index b25086f252ae..a097a59a9eae 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> @@ -663,11 +663,6 @@ void oaktrail_hdmi_init(struct drm_device *dev,
> kfree(gma_encoder);
> }
>
> -static const struct pci_device_id hdmi_ids[] = {
> - { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x080d) },
> - { 0 }
> -};
> -
> void oaktrail_hdmi_setup(struct drm_device *dev)
> {
> struct drm_psb_private *dev_priv = dev->dev_private;
> --
> 2.17.1
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2020-04-17 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 10:10 YueHaibing
2020-04-17 15:24 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417152414.GR3456981@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®