From: David Miller <davem@davemloft.net>
To: tanhuazhong@huawei.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
salil.mehta@huawei.com, yisen.zhuang@huawei.com,
linuxarm@huawei.com, kuba@kernel.org, shenjian15@huawei.com
Subject: Re: [PATCH net-next 01/10] net: hns3: split out hclge_fd_check_ether_tuple()
Date: Sat, 18 Apr 2020 20:17:46 -0700 (PDT) [thread overview]
Message-ID: <20200418.201746.783676213458110248.davem@davemloft.net> (raw)
In-Reply-To: <1587192429-11463-2-git-send-email-tanhuazhong@huawei.com>
From: Huazhong Tan <tanhuazhong@huawei.com>
Date: Sat, 18 Apr 2020 14:47:00 +0800
> +static int hclge_fd_check_spec(struct hclge_dev *hdev,
> + struct ethtool_rx_flow_spec *fs,
> + u32 *unused_tuple)
> +{
> + int ret = 0;
There is no code path that uses 'ret' without it first being
assigned. If I let this code in, then someone is going to
submit a fixup patch removing the initialization.
next prev parent reply other threads:[~2020-04-19 3:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 6:46 [PATCH net-next 00/10] net: hns3: misc updates for -next Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 01/10] net: hns3: split out hclge_fd_check_ether_tuple() Huazhong Tan
2020-04-19 3:17 ` David Miller [this message]
2020-04-20 1:04 ` tanhuazhong
2020-04-18 6:47 ` [PATCH net-next 02/10] net: hns3: split out hclge_get_fd_rule_info() Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 03/10] net: hns3: remove an unnecessary case 0 in hclge_fd_convert_tuple() Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 04/10] net: hns3: remove useless proto_support field in struct hclge_fd_cfg Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 05/10] net: hns3: remove two unused structures in hclge_cmd.h Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 06/10] net: hns3: modify some unsuitable type declaration Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 07/10] net: hns3: clean up some coding style issue Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 08/10] net: hns3: add debug information for flow table when failed Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 09/10] net: hns3: add support of dumping MAC reg in debugfs Huazhong Tan
2020-04-18 6:47 ` [PATCH net-next 10/10] net: hns3: add trace event support for PF/VF mailbox Huazhong Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418.201746.783676213458110248.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®