From: Sedat Dilek <sedat.dilek@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Jessica Yu <jeyu@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Sedat Dilek <sedat.dilek@gmail.com>
Subject: [RFC PATCH 2/2] kbuild: Rename and use BINUTILS_VERSION where needed
Date: Sun, 19 Apr 2020 15:21:42 +0200 [thread overview]
Message-ID: <20200419132142.173861-1-sedat.dilek@gmail.com> (raw)
In the first patch I introduced LD_IS_BINUTILS Kconfig.
To be consistent in naming convention I renamed from LD_VERSION
to BINUTILS_VERSION.
So, we have the double "LD_IS_BINUTILS" and "BINUTILS_VERSION"
like "CC_IS_GCC" and "GCC_VERSION".
For the same reason I renamed the shell script to detect the GNU ld
linker version.
In Documentation/process/changes.rst we use "binutils" and GNU ld
binary is part of it (see [3]).
The patches "init/kconfig: Add LD_VERSION Kconfig" (see [1]) and
"arm64: Kconfig: ptrauth: Add binutils version check to fix mismatch"
(see [2]) added checks for binutils >=2.23.1 whereas binutils
version 2.23 is minimum supported version (see [3]).
I have renamed to BINUTILS_VERSION where needed.
[1] https://git.kernel.org/linus/9553d16fa671b9621c5e2847d08bd90d3be3349c
[2] https://git.kernel.org/linus/15cd0e675f3f76b4d21c313795fe0c23df0ee20f
[3] https://git.kernel.org/linus/Documentation/process/changes.rst#n79
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
arch/arm64/Kconfig | 2 +-
init/Kconfig | 4 ++--
scripts/{ld-version.sh => binutils-version.sh} | 0
3 files changed, 3 insertions(+), 3 deletions(-)
rename scripts/{ld-version.sh => binutils-version.sh} (100%)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 40fb05d96c60..274ba9b3ac95 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -1504,7 +1504,7 @@ config ARM64_PTR_AUTH
depends on (CC_HAS_SIGN_RETURN_ADDRESS || CC_HAS_BRANCH_PROT_PAC_RET) && AS_HAS_PAC
# GCC 9.1 and later inserts a .note.gnu.property section note for PAC
# which is only understood by binutils starting with version 2.33.1.
- depends on !CC_IS_GCC || GCC_VERSION < 90100 || LD_VERSION >= 233010000
+ depends on !CC_IS_GCC || GCC_VERSION < 90100 || BINUTILS_VERSION >= 233010000
depends on !CC_IS_CLANG || AS_HAS_CFI_NEGATE_RA_STATE
depends on (!FUNCTION_GRAPH_TRACER || DYNAMIC_FTRACE_WITH_REGS)
help
diff --git a/init/Kconfig b/init/Kconfig
index 520116efea0f..946db4786951 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -19,9 +19,9 @@ config GCC_VERSION
config LD_IS_BINUTILS
def_bool $(success,$(LD) -v | head -n 1 | grep -q 'GNU ld')
-config LD_VERSION
+config BINUTILS_VERSION
int
- default $(shell,$(LD) --version | $(srctree)/scripts/ld-version.sh) if LD_IS_BINUTILS
+ default $(shell,$(LD) --version | $(srctree)/scripts/binutils-version.sh) if LD_IS_BINUTILS
config CC_IS_CLANG
def_bool $(success,$(CC) --version | head -n 1 | grep -q clang)
diff --git a/scripts/ld-version.sh b/scripts/binutils-version.sh
similarity index 100%
rename from scripts/ld-version.sh
rename to scripts/binutils-version.sh
--
2.26.1
next reply other threads:[~2020-04-19 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 13:21 Sedat Dilek [this message]
2020-04-19 16:40 ` Nathan Chancellor
2020-04-24 2:38 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419132142.173861-1-sedat.dilek@gmail.com \
--to=sedat.dilek@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=ebiederm@xmission.com \
--cc=jeyu@kernel.org \
--cc=joel@joelfernandes.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mhiramat@kernel.org \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®