From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE0FC3815B for ; Mon, 20 Apr 2020 10:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 580B320A8B for ; Mon, 20 Apr 2020 10:28:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="SjzHA46n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726117AbgDTK2B (ORCPT ); Mon, 20 Apr 2020 06:28:01 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:21998 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbgDTK2B (ORCPT ); Mon, 20 Apr 2020 06:28:01 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03KAR8nZ027670; Mon, 20 Apr 2020 05:27:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=XMZJ4++bf6kK1/gYDj2WIPoTv3BH10ggIzYMTgvPcsU=; b=SjzHA46nlJ+SvDR3LFzPbsVKjU/j/UuqCvXmCqr81Kyf6aeiG6cjEaLvZZsdbpO2b68p Ywn0UqHP4+8dTx2si2E16xCGzCR83Hclsd0ELbidToy+JUZpQSw2bhZNTbBqOu2yqDfk OaG0aI10jXg5TFD+yXhOvzAZj68/lG6SFU2zyJlbkKYz0pgRg6vVGhfZiynQ4G89PkiH ko78nkNhBZaX0OcTKh4OS9+caezFMQ8Tikvr0DHd1Zoj371Z7IAtkpTFFv0taYm6Y1ts KbM7pkqvpTzz3mh7IZCs9n1jaCGgLelym7befgGiJ3sg0suMCloMbvgt1ECHWJnn2C8H Og== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 30fwyqjv3t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 20 Apr 2020 05:27:08 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Mon, 20 Apr 2020 11:27:01 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1591.10 via Frontend Transport; Mon, 20 Apr 2020 11:27:01 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 023252AB; Mon, 20 Apr 2020 10:27:01 +0000 (UTC) Date: Mon, 20 Apr 2020 10:27:01 +0000 From: Charles Keepax To: YueHaibing CC: , , , , , , Subject: Re: [PATCH] ASoC: wm89xx: Fix build error without CONFIG_I2C Message-ID: <20200420102701.GB44490@ediswmail.ad.cirrus.com> References: <20200418090853.30340-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200418090853.30340-1-yuehaibing@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com ip4:5.172.152.52 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 priorityscore=1501 mlxlogscore=776 clxscore=1015 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004200094 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 18, 2020 at 05:08:53PM +0800, YueHaibing wrote: > sound/soc/codecs/wm8900.o: In function `wm8900_i2c_probe': > wm8900.c:(.text+0xa36): undefined reference to `__devm_regmap_init_i2c' > sound/soc/codecs/wm8900.o: In function `wm8900_modinit': > wm8900.c:(.init.text+0xb): undefined reference to `i2c_register_driver' > sound/soc/codecs/wm8900.o: In function `wm8900_exit': > wm8900.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' > sound/soc/codecs/wm8988.o: In function `wm8988_i2c_probe': > wm8988.c:(.text+0x857): undefined reference to `__devm_regmap_init_i2c' > sound/soc/codecs/wm8988.o: In function `wm8988_modinit': > wm8988.c:(.init.text+0xb): undefined reference to `i2c_register_driver' > sound/soc/codecs/wm8988.o: In function `wm8988_exit': > wm8988.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' > sound/soc/codecs/wm8995.o: In function `wm8995_i2c_probe': > wm8995.c:(.text+0x1c4f): undefined reference to `__devm_regmap_init_i2c' > sound/soc/codecs/wm8995.o: In function `wm8995_modinit': > wm8995.c:(.init.text+0xb): undefined reference to `i2c_register_driver' > sound/soc/codecs/wm8995.o: In function `wm8995_exit': > wm8995.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' > > Add missing I2C dependency to fix this. > This doesn't look like the right fix there, all these parts can be used on SPI so should be usable without I2C build in. Thanks, Charles