From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: linux-mips@vger.kernel.org
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Rob Herring <robh+dt@kernel.org>, Huacai Chen <chenhc@lemote.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/5] MIPS: Loongson64: Mark RS780 HPET as broken
Date: Mon, 20 Apr 2020 21:45:29 +0800 [thread overview]
Message-ID: <20200420134536.210475-5-jiaxun.yang@flygoat.com> (raw)
In-Reply-To: <20200420134536.210475-1-jiaxun.yang@flygoat.com>
This driver is using some dangerous hack to set MMIO address for HPET,
which might break systems with other kinds of PCH.
Also, as Loongson-3 cpufreq driver never appeared in mainline,
this driver rarely got used.
So we temporarily mark it as broken until we find a better solution.
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
arch/mips/loongson64/Kconfig | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/mips/loongson64/Kconfig b/arch/mips/loongson64/Kconfig
index c386b8a3c753..517f1f8e81fb 100644
--- a/arch/mips/loongson64/Kconfig
+++ b/arch/mips/loongson64/Kconfig
@@ -4,14 +4,12 @@ if MACH_LOONGSON64
config RS780_HPET
bool "RS780/SBX00 HPET Timer"
depends on MACH_LOONGSON64
+ depends on BROKEN
select MIPS_EXTERNAL_TIMER
help
This option enables the hpet timer of AMD RS780/SBX00.
- If you want to enable the Loongson3 CPUFreq Driver, Please enable
- this option at first, otherwise, You will get wrong system time.
-
- If unsure, say Yes.
-
+ Note: This driver is doing some dangerous hack. Please only enable
+ it on RS780E systems.
endif # MACH_LOONGSON64
--
2.26.0.rc2
next prev parent reply other threads:[~2020-04-20 13:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 7:33 [PATCH RESEND 0/5] Loongson64: RS780E clean-ups Jiaxun Yang
2020-04-20 7:33 ` [PATCH RESEND 1/5] MIPS: Loongson64: Remove dead RTC code Jiaxun Yang
2020-04-20 12:06 ` maobibo
2020-04-20 12:13 ` Jiaxun Yang
2020-04-20 13:04 ` maobibo
2020-04-20 13:15 ` Jiaxun Yang
2020-04-20 7:33 ` [PATCH RESEND 2/5] MIPS: Loongson64: Make RS780E ACPI as a platform driver Jiaxun Yang
2020-04-20 7:33 ` [PATCH RESEND 3/5] dt-bindings: Document Loongson RS780E PCH ACPI Controller Jiaxun Yang
2020-04-20 7:33 ` [PATCH RESEND 4/5] MIPS: DTS: Loongson64: Add ACPI Controller Node Jiaxun Yang
2020-04-20 7:33 ` [PATCH RESEND 5/5] MIPS: Loongson64: Mark RS780 HPET as broken Jiaxun Yang
2020-04-20 9:07 ` [PATCH RESEND 0/5] Loongson64: RS780E clean-ups Thomas Bogendoerfer
2020-04-20 9:31 ` Jiaxun Yang
2020-04-20 13:45 ` [PATCH v2 1/5] MIPS: Loongson64: Remove dead RTC code Jiaxun Yang
2020-04-20 13:45 ` [PATCH v2 2/5] MIPS: Loongson64: Make RS780E ACPI as a platform driver Jiaxun Yang
2020-04-20 13:45 ` [PATCH v2 3/5] dt-bindings: Document Loongson RS780E PCH ACPI Controller Jiaxun Yang
2020-04-20 13:45 ` [PATCH v2 4/5] MIPS: DTS: Loongson64: Add ACPI Controller Node Jiaxun Yang
2020-04-20 13:45 ` Jiaxun Yang [this message]
2020-04-20 17:40 ` [PATCH v2 1/5] MIPS: Loongson64: Remove dead RTC code Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420134536.210475-5-jiaxun.yang@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=chenhc@lemote.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®