From: David Sterba <dsterba@suse.cz>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>, Chris Mason <clm@fb.com>,
Jeff Mahoney <jeffm@suse.com>,
wqu@suse.com
Subject: Re: [PATCH] btrfs: move enum btrfs_compression_type to the UAPI header
Date: Tue, 21 Apr 2020 00:10:03 +0200 [thread overview]
Message-ID: <20200420221003.GG18421@twin.jikos.cz> (raw)
In-Reply-To: <20200419101432.GA32249@asgard.redhat.com>
On Sun, Apr 19, 2020 at 12:14:32PM +0200, Eugene Syromiatnikov wrote:
> It is passed in struct btrfs_ioctl_defrag_range_args.compress_type
> to BTRFS_IOC_DEFRAG_RANGE, so it has to be a part of UAPI.
> Also, rely on enum definition rules to get BTRFS_NR_COMPRESS_TYPES
> value and mark it as non-ABI.
Adding the compression types makes sense for the UAPI, Qu has sent patch
to move more code to the exported headers ("btrfs: move on-disk
structure definitions to btrfs_tree.h"), including the compression type
definition.
I'd prefer to move the code in a bigger chunk than one by one, unless
it's breaking compilation.
prev parent reply other threads:[~2020-04-20 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 10:14 Eugene Syromiatnikov
2020-04-20 22:10 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420221003.GG18421@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=esyr@redhat.com \
--cc=jeffm@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®