From: David Miller <davem@davemloft.net>
To: vee.khee.wong@intel.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, boon.leong.ong@intel.com,
weifeng.voon@intel.com
Subject: Re: [PATCH net-next 1/1] net: stmmac: Add support for VLAN promiscuous mode
Date: Tue, 21 Apr 2020 15:41:53 -0700 (PDT) [thread overview]
Message-ID: <20200421.154153.172396683183248740.davem@davemloft.net> (raw)
In-Reply-To: <20200420033359.11610-1-vee.khee.wong@intel.com>
From: Wong Vee Khee <vee.khee.wong@intel.com>
Date: Mon, 20 Apr 2020 11:33:59 +0800
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index e6898fd5223f..80250c7be783 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -4877,7 +4877,6 @@ int stmmac_dvr_probe(struct device *device,
> }
> }
>
> - ndev->features |= ndev->hw_features | NETIF_F_HIGHDMA;
> ndev->watchdog_timeo = msecs_to_jiffies(watchdog);
> #ifdef STMMAC_VLAN_TAG_USED
> /* Both mac100 and gmac support receive VLAN tag detection */
> @@ -4892,6 +4891,7 @@ int stmmac_dvr_probe(struct device *device,
> ndev->features |= NETIF_F_HW_VLAN_STAG_TX;
> }
> #endif
> + ndev->features |= ndev->hw_features | NETIF_F_HIGHDMA;
> priv->msg_enable = netif_msg_init(debug, default_msg_level);
This change has no effect, because hw_features does not change across
this code block you are moving the line across.
So please remove this part of the patch it is pointless and makes your
change harder to review.
prev parent reply other threads:[~2020-04-21 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 3:33 Wong Vee Khee
2020-04-21 22:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421.154153.172396683183248740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=boon.leong.ong@intel.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vee.khee.wong@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®