From: Steven Rostedt <rostedt@goodmis.org>
To: Waiman Long <longman@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ingo Molnar <mingo@redhat.com>,
Tejun Heo <tj@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH] blk-iocost: Fix systemtap error on iocost_ioc_vrate_adj
Date: Tue, 21 Apr 2020 10:59:48 -0400 [thread overview]
Message-ID: <20200421105948.4f5a36f5@gandalf.local.home> (raw)
In-Reply-To: <20200421130755.18370-1-longman@redhat.com>
On Tue, 21 Apr 2020 09:07:55 -0400
Waiman Long <longman@redhat.com> wrote:
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> index 7ecaa65b7106..c2f580fd371b 100644
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
> @@ -130,7 +130,7 @@ DEFINE_EVENT(iocg_inuse_update, iocost_inuse_reset,
>
> TRACE_EVENT(iocost_ioc_vrate_adj,
>
> - TP_PROTO(struct ioc *ioc, u64 new_vrate, u32 (*missed_ppm)[2],
> + TP_PROTO(struct ioc *ioc, u64 new_vrate, u32 *missed_ppm,
> u32 rq_wait_pct, int nr_lagging, int nr_shortages,
> int nr_surpluses),
>
> @@ -155,8 +155,8 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
> __entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
> __entry->new_vrate = new_vrate;
> __entry->busy_level = ioc->busy_level;
> - __entry->read_missed_ppm = (*missed_ppm)[READ];
> - __entry->write_missed_ppm = (*missed_ppm)[WRITE];
> + __entry->read_missed_ppm = missed_ppm[READ];
> + __entry->write_missed_ppm = missed_ppm[WRITE];
> __entry->rq_wait_pct = rq_wait_pct;
> __entry->nr_lagging = nr_lagging;
> __entry->nr_shortages = nr_shortages;
Regardless if this helps systemtap or not, I like the patch because the
current code is rather ugly, and this patch makes it more readable.
Suggestion: change the topic to remove systemtap, as that's not going to be
the true reason for acceptance of this patch. It should just be about
cleaning up the trace event itself.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2020-04-21 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 13:07 Waiman Long
2020-04-21 14:59 ` Steven Rostedt [this message]
2020-04-21 18:36 ` Waiman Long
2020-04-21 19:16 ` Steven Rostedt
2020-04-21 19:17 ` Jens Axboe
2020-04-21 19:28 ` Waiman Long
2020-04-21 15:23 ` Tejun Heo
2020-04-21 15:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421105948.4f5a36f5@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=mingo@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®