From: Dan Carpenter <dan.carpenter@oracle.com>
To: Denis Straghkov <d.straghkov@ispras.ru>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: rtw_wlan_util: Add size check of SSID IE
Date: Tue, 21 Apr 2020 21:01:02 +0300 [thread overview]
Message-ID: <20200421180102.GF2659@kadam> (raw)
In-Reply-To: <20200421170806.18783-1-d.straghkov@ispras.ru>
On Tue, Apr 21, 2020 at 08:08:06PM +0300, Denis Straghkov wrote:
> /* checking SSID */
> + ssid_len = 0;
> p = rtw_get_ie(bssid->IEs + _FIXED_IE_LENGTH_, _SSID_IE_, &len, bssid->IELength - _FIXED_IE_LENGTH_);
> - if (!p) {
> - DBG_871X("%s marc: cannot find SSID for survey event\n", __func__);
> - hidden_ssid = true;
> - } else {
> - hidden_ssid = false;
> - }
> -
> - if ((NULL != p) && (false == hidden_ssid && (*(p + 1)))) {
> - memcpy(bssid->Ssid.Ssid, (p + 2), *(p + 1));
> - bssid->Ssid.SsidLength = *(p + 1);
> - } else {
> - bssid->Ssid.SsidLength = 0;
> - bssid->Ssid.Ssid[0] = '\0';
> - }
> + if (p) {
> + ssid_len = *(p + 1);
> + if (ssid_len > NDIS_802_11_LENGTH_SSID)
> + ssid_len = 0;
> + }
> + memcpy(bssid->Ssid.Ssid, (p + 2), ssid_len);
> + bssid->Ssid.SsidLength = ssid_len;
This is using spaces instead of tabs. Please run ./scripts/checkpatch.pl
on your patch.
regargs,
dan carpenter
prev parent reply other threads:[~2020-04-21 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 17:08 Denis Straghkov
2020-04-21 18:01 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421180102.GF2659@kadam \
--to=dan.carpenter@oracle.com \
--cc=d.straghkov@ispras.ru \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®