From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com,
linux-kernel@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net v2 0/5] net: dsa: b53: Various ARL fixes
Date: Wed, 22 Apr 2020 12:53:40 -0700 (PDT) [thread overview]
Message-ID: <20200422.125340.55926071085123839.davem@davemloft.net> (raw)
In-Reply-To: <20200421032655.5537-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 20 Apr 2020 20:26:50 -0700
> Hi David, Andrew, Vivien, Jakub,
>
> This patch series fixes a number of short comings in the existing b53
> driver ARL management logic in particular:
>
> - we were not looking up the {MAC,VID} tuples against their VID, despite
> having VLANs enabled
>
> - the MDB entries (multicast) would lose their validity as soon as a
> single port in the vector would leave the entry
>
> - the ARL was currently under utilized because we would always place new
> entries in bin index #1, instead of using all possible bins available,
> thus reducing the ARL effective size by 50% or 75% depending on the
> switch generation
>
> - it was possible to overwrite the ARL entries because no proper space
> verification was done
>
> This patch series addresses all of these issues.
>
> Changes in v2:
> - added a new patch to correctly flip invidual VLAN learning vs. shared
> VLAN learning depending on the global VLAN state
>
> - added Andrew's R-b tags for patches which did not change
>
> - corrected some verbosity and minor issues in patch #4 to match caller
> expectations, also avoid a variable length DECLARE_BITMAP() call
Series applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-04-22 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 3:26 Florian Fainelli
2020-04-21 3:26 ` [PATCH net v2 1/5] net: dsa: b53: Lookup VID in ARL searches when VLAN is enabled Florian Fainelli
2020-04-21 3:26 ` [PATCH net v2 2/5] net: dsa: b53: Fix valid setting for MDB entries Florian Fainelli
2020-04-21 3:26 ` [PATCH net v2 3/5] net: dsa: b53: Fix ARL register definitions Florian Fainelli
2020-04-21 3:26 ` [PATCH net v2 4/5] net: dsa: b53: Rework ARL bin logic Florian Fainelli
2020-04-21 3:26 ` [PATCH net v2 5/5] net: dsa: b53: b53_arl_rw_op() needs to select IVL or SVL Florian Fainelli
2020-04-22 19:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422.125340.55926071085123839.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®