From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0DB3C54FCB for ; Thu, 23 Apr 2020 22:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAAD220724 for ; Thu, 23 Apr 2020 22:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbgDWWdJ (ORCPT ); Thu, 23 Apr 2020 18:33:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbgDWWdJ (ORCPT ); Thu, 23 Apr 2020 18:33:09 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C25AC09B042; Thu, 23 Apr 2020 15:33:09 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C8D71127D6DDB; Thu, 23 Apr 2020 15:33:06 -0700 (PDT) Date: Thu, 23 Apr 2020 15:33:03 -0700 (PDT) Message-Id: <20200423.153303.460318719995342920.davem@davemloft.net> To: tangbin@cmss.chinamobile.com Cc: kuba@kernel.org, khalasa@piap.pl, linus.walleij@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshengju@cmss.chinamobile.com Subject: Re: [PATCH v3] net: ethernet: ixp4xx: Add error handling in ixp4xx_eth_probe() From: David Miller In-Reply-To: <20200423021631.20800-1-tangbin@cmss.chinamobile.com> References: <20200423021631.20800-1-tangbin@cmss.chinamobile.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 Apr 2020 15:33:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin Date: Thu, 23 Apr 2020 10:16:31 +0800 > The function ixp4xx_eth_probe() does not perform sufficient error > checking after executing devm_ioremap_resource(), which can result > in crashes if a critical error path is encountered. > > Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base as resource") > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied, thank you.