From: Mark Brown <broonie@kernel.org>
To: Rong Chen <rong.a.chen@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kbuild test robot <lkp@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH] ASoC: soc-compress: avoid false-positive Wuninitialized warning
Date: Thu, 23 Apr 2020 14:49:24 +0100 [thread overview]
Message-ID: <20200423134924.GA53068@sirena.org.uk> (raw)
In-Reply-To: <20200422073543.1671-1-rong.a.chen@intel.com>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
On Wed, Apr 22, 2020 at 03:35:43PM +0800, Rong Chen wrote:
> gcc-6.5 and earlier show a new warning:
>
> sound/soc/soc-compress.c: In function ‘soc_compr_open’:
> sound/soc/soc-compress.c:75:28: warning: ‘component’ is used uninitialized in this function [-Wuninitialized]
> struct snd_soc_component *component, *save = NULL;
> ^~~~~~~~~
> Simplest fix is to initialize it to avoid the warning.
This doesn't apply against current code, please check and resend. TBH
I'm not 100% sure the benefit here is worth it, this is a very old
compiler and it seems like a bug in the compiler.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-23 13:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 7:53 sound/soc/soc-compress.c:75:28: warning: 'component' is used uninitialized in this function kbuild test robot
2020-04-21 6:23 ` Kuninori Morimoto
2020-04-22 1:17 ` [kbuild-all] " Rong Chen
2020-04-22 4:53 ` Kuninori Morimoto
2020-04-22 7:39 ` Rong Chen
2020-04-22 7:35 ` [PATCH] ASoC: soc-compress: avoid false-positive Wuninitialized warning Rong Chen
2020-04-22 22:18 ` Kuninori Morimoto
2020-04-23 13:49 ` Mark Brown [this message]
2020-04-24 12:19 ` Mark Brown
2020-04-24 0:54 ` [PATCH v2] " Rong Chen
2020-04-24 4:34 ` Kuninori Morimoto
2020-04-24 12:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423134924.GA53068@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=perex@perex.cz \
--cc=rong.a.chen@intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®