From: Wang Wenhu <wenhu.wang@vivo.com>
To: arnd@arndb.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: rdunlap@infradead.org, kernel@vivo.com, Wang Wenhu <wenhu.wang@vivo.com>
Subject: [PATCH v3] io: correct doc-mismatches for io mem ops
Date: Thu, 23 Apr 2020 19:08:31 -0700 [thread overview]
Message-ID: <20200424020831.30494-1-wenhu.wang@vivo.com> (raw)
Minor mismatches exist between funtion documentations and parameter
definitions. Also a dash '-' is needed between a function name and
its description.
Function definitions are as following:
static inline void memset_io(volatile void __iomem *addr, int value,
size_t size)
static inline void memcpy_fromio(void *buffer,
const volatile void __iomem *addr,
size_t size)
static inline void memcpy_toio(volatile void __iomem *addr, const void *buffer,
size_t size)
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
---
include/asm-generic/io.h | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
index d39ac997dda8..83ac47bfa33a 100644
--- a/include/asm-generic/io.h
+++ b/include/asm-generic/io.h
@@ -1049,10 +1049,10 @@ static inline void *bus_to_virt(unsigned long address)
#ifndef memset_io
#define memset_io memset_io
/**
- * memset_io Set a range of I/O memory to a constant value
+ * memset_io - Set a range of I/O memory to a constant value
* @addr: The beginning of the I/O-memory range to set
- * @val: The value to set the memory to
- * @count: The number of bytes to set
+ * @value: The value to set the memory to
+ * @size: The number of bytes to set
*
* Set a range of I/O memory to a given value.
*/
@@ -1066,10 +1066,10 @@ static inline void memset_io(volatile void __iomem *addr, int value,
#ifndef memcpy_fromio
#define memcpy_fromio memcpy_fromio
/**
- * memcpy_fromio Copy a block of data from I/O memory
- * @dst: The (RAM) destination for the copy
- * @src: The (I/O memory) source for the data
- * @count: The number of bytes to copy
+ * memcpy_fromio - Copy a block of data from I/O memory
+ * @buffer: The (RAM) destination for the copy
+ * @addr: The (I/O memory) source for the data
+ * @size: The number of bytes to copy
*
* Copy a block of data from I/O memory.
*/
@@ -1084,10 +1084,10 @@ static inline void memcpy_fromio(void *buffer,
#ifndef memcpy_toio
#define memcpy_toio memcpy_toio
/**
- * memcpy_toio Copy a block of data into I/O memory
- * @dst: The (I/O memory) destination for the copy
- * @src: The (RAM) source for the data
- * @count: The number of bytes to copy
+ * memcpy_toio - Copy a block of data into I/O memory
+ * @addr: The (I/O memory) destination for the copy
+ * @buffer: The (RAM) source for the data
+ * @size: The number of bytes to copy
*
* Copy a block of data to I/O memory.
*/
--
2.17.1
next reply other threads:[~2020-04-24 2:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 2:08 Wang Wenhu [this message]
2020-04-24 2:10 ` Randy Dunlap
2020-04-24 2:17 ` 王文虎
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424020831.30494-1-wenhu.wang@vivo.com \
--to=wenhu.wang@vivo.com \
--cc=arnd@arndb.de \
--cc=kernel@vivo.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®