From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBBEC55192 for ; Fri, 24 Apr 2020 04:54:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E2C22075A for ; Fri, 24 Apr 2020 04:54:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VU1s+LT3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbgDXEyW (ORCPT ); Fri, 24 Apr 2020 00:54:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726337AbgDXEyT (ORCPT ); Fri, 24 Apr 2020 00:54:19 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEE7EC09B048 for ; Thu, 23 Apr 2020 21:54:18 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id g2so3316278plo.3 for ; Thu, 23 Apr 2020 21:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z/YsFv/10NhkBeiZjaV6l6O7A2swaX/eVpoeaYwPiNg=; b=VU1s+LT31TEalxhE+dHeMgtEMRrST5oIP96hg6VW4pHGnP+qE7kUxu38tEe52CypLI xuKf3XnGnEDYe3ajNmaDD67pxCiXLlDvRJ5Fxn4hSq61lETE0fcgJ4nc9BHFQegGTQZk Q6saQBat6gqeg9CpStPfAtuouhMP8wx4u6uhk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z/YsFv/10NhkBeiZjaV6l6O7A2swaX/eVpoeaYwPiNg=; b=Hto2NBxWXfgoUzvMpXP7rtQSQugCQxAeytTn7/W4ijPiyqktsIB0zl15RI2GT9suvG 45lKwIhRyx+XilGK93qGxuajTY6VAfGpD1JhyJP5a6FLY+D0U428B8rZ2ccqm/6CBEIm qwOBaeXKP2TcpRauDUSfeFM/TJZdUrDwaVPauJ6506tqhDYVC7Z175beq7lOuhKHEf1t ZjtlnsN+T2fFPiyLJzRSkXNuF8z7tZ0k56TPTXECts5EAdne4W3qhL+ZnqYQvmvAs71c suSm/Hj7vrlGlNq1CCyuSVUX8rY+m4oEiJdvtJUpP2VQy/yHMAeUWVDtSm0QAtwO1kko 5wlA== X-Gm-Message-State: AGi0PuYj+0BXNGRQsMtyXtO5nR9jqhoyUNwFhZ1t3cVRowxhDivl9sjl Aq3Cv98ZczO2rnL/8qBcdBcl+Q== X-Google-Smtp-Source: APiQypI6m7J+NqwxX2iu4a6RtckM854S3bBsQf98LAgWiQRqbCtnJRyA11TOuBgHg51CtgGWm2KTmQ== X-Received: by 2002:a17:902:7148:: with SMTP id u8mr6922882plm.13.1587704058295; Thu, 23 Apr 2020 21:54:18 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id 62sm4344680pfu.181.2020.04.23.21.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 21:54:17 -0700 (PDT) From: Stephen Boyd To: Andy Gross , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Maulik Shah , Douglas Anderson Subject: [PATCH 3/3] soc: qcom: rpmh-rsc: Fold WARN_ON() into if condition Date: Thu, 23 Apr 2020 21:54:14 -0700 Message-Id: <20200424045414.133381-4-swboyd@chromium.org> X-Mailer: git-send-email 2.26.2.303.gf8c07b1a785-goog In-Reply-To: <20200424045414.133381-1-swboyd@chromium.org> References: <20200424045414.133381-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move the WARN_ON() into the if condition so the compiler can see that the branch is unlikely() and possibly optimize it better. Cc: Maulik Shah Cc: Douglas Anderson Signed-off-by: Stephen Boyd --- drivers/soc/qcom/rpmh-rsc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index 462dd267afef..f7763f008e03 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -373,10 +373,8 @@ static irqreturn_t tcs_tx_done(int irq, void *p) for_each_set_bit(i, &irq_status, BITS_PER_TYPE(u32)) { req = get_req_from_tcs(drv, i); - if (!req) { - WARN_ON(1); + if (WARN_ON(!req)) goto skip; - } err = 0; for (j = 0; j < req->num_cmds; j++) { -- Sent by a computer, using git, on the internet