From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paolo Pisati <paolo.pisati@canonical.com>
Cc: Jiri Slaby <jslaby@suse.com>, Dmitry Safonov <dima@arista.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysrq: export sysrq_mask symbol
Date: Fri, 24 Apr 2020 11:04:36 +0200 [thread overview]
Message-ID: <20200424090436.GA358113@kroah.com> (raw)
In-Reply-To: <20200424085347.40185-1-paolo.pisati@canonical.com>
On Fri, Apr 24, 2020 at 10:53:46AM +0200, Paolo Pisati wrote:
> Commit "68af431 serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE" breaks
> the build if CONFIG_SERIAL_CORE=m:
>
> ...
> ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1331: modules] Error 2
>
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
> drivers/tty/sysrq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 5e0d0813da55..cf49010335fd 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -74,6 +74,7 @@ int sysrq_mask(void)
> return 1;
> return sysrq_enabled;
> }
> +EXPORT_SYMBOL(sysrq_mask);
>
> /*
> * A value of 1 means 'all', other nonzero values are an op mask:
Already in my tty tree, will go to Linus tomorrow, thanks!
greg k-h
prev parent reply other threads:[~2020-04-24 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 8:53 Paolo Pisati
2020-04-24 9:04 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424090436.GA358113@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dima@arista.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.pisati@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome