From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7D7C54FCB for ; Fri, 24 Apr 2020 12:28:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89A8B20700 for ; Fri, 24 Apr 2020 12:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731310; bh=21jnwet0trPW2Kv3E6ihRnckW6TR5od8KkJAPHwPeqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1HLSHHZNnXNfeN66+McXnYMyw0NuSMaP7rNNU7iCQUT9qZC5lcLAeep9TQzX9eRqO gKGCeepuCK6rKv+kSstq0EPsaJCcce9uFXoRRM++Z7qKE77LaJMsHybX5sA2O9gU3P b1uJuO25EcHmqdxC0SxhaXLu4ig/7ChQVTgq7arA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728691AbgDXM22 (ORCPT ); Fri, 24 Apr 2020 08:28:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:54734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728325AbgDXMYP (ORCPT ); Fri, 24 Apr 2020 08:24:15 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B20D621835; Fri, 24 Apr 2020 12:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731055; bh=21jnwet0trPW2Kv3E6ihRnckW6TR5od8KkJAPHwPeqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L7W/2T83CUnd5AGRNZR9YaKAv87omwC9MfZ0t+RxJSHbBE4uoqNHvZrREM1Y3Z+Jd OXbPVg3S+37kF6Yy6+hpfEXlBpfKAxezBV23jJ8qrHRqqjINVrefxQBLlltg+4SQ9S geXIIjMiBq8aQq9M540rGheejGhYp8+srUIHrj8E= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Theodore Ts'o , Sasha Levin , linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 16/18] ext4: increase wait time needed before reuse of deleted inode numbers Date: Fri, 24 Apr 2020 08:23:53 -0400 Message-Id: <20200424122355.10453-16-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200424122355.10453-1-sashal@kernel.org> References: <20200424122355.10453-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Theodore Ts'o [ Upstream commit a17a9d935dc4a50acefaf319d58030f1da7f115a ] Current wait times have proven to be too short to protect against inode reuses that lead to metadata inconsistencies. Now that we will retry the inode allocation if we can't find any recently deleted inodes, it's a lot safer to increase the recently deleted time from 5 seconds to a minute. Link: https://lore.kernel.org/r/20200414023925.273867-1-tytso@mit.edu Google-Bug-Id: 36602237 Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/ialloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index dafa7e4aaecb9..8876eaad10f68 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -665,7 +665,7 @@ static int find_group_other(struct super_block *sb, struct inode *parent, * block has been written back to disk. (Yes, these values are * somewhat arbitrary...) */ -#define RECENTCY_MIN 5 +#define RECENTCY_MIN 60 #define RECENTCY_DIRTY 300 static int recently_deleted(struct super_block *sb, ext4_group_t group, int ino) -- 2.20.1