From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C96AFC55191 for ; Fri, 24 Apr 2020 12:24:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AEAD21707 for ; Fri, 24 Apr 2020 12:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731046; bh=CriRCGClvamC+iFzH8OrWMWdqSTNirz+iZj25GHP8jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rSaAmND/sO27B4plc67NU7AE6cDeVE4dmPiNWADUTIn4Su2S7qwzI/xkOGv0GRpiv tWcVSz3JmXtYSU+r8eVLvWIEXqzNYglPghZaaZtBoQVOBcFoJaNy3ryJP+webw3oba 2KgFrSQnYNDxhuqAIHNtHfdQleGIyBt1fwZwnU3s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728262AbgDXMYF (ORCPT ); Fri, 24 Apr 2020 08:24:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:54294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728240AbgDXMYB (ORCPT ); Fri, 24 Apr 2020 08:24:01 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83B942168B; Fri, 24 Apr 2020 12:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731041; bh=CriRCGClvamC+iFzH8OrWMWdqSTNirz+iZj25GHP8jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CVLZLV67ee2Gn6DqPHhYI8cAcHw9+l3IPDVBh0hWVRz31DoLF0Odowsq5g6mFHoCy TZM1ue+Dh8I4Z3rClY8NdrACd0T8G4Oa0bLBftfSa0LXT/44059bq85NcjPTwJRZK8 W9xUEqLF/UqhjxF8T4v9Tw3ZqRKNyCXhISJWsM6c= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Darrick J. Wong" , Brian Foster , Sasha Levin , linux-xfs@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 04/18] xfs: fix partially uninitialized structure in xfs_reflink_remap_extent Date: Fri, 24 Apr 2020 08:23:41 -0400 Message-Id: <20200424122355.10453-4-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200424122355.10453-1-sashal@kernel.org> References: <20200424122355.10453-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Darrick J. Wong" [ Upstream commit c142932c29e533ee892f87b44d8abc5719edceec ] In the reflink extent remap function, it turns out that uirec (the block mapping corresponding only to the part of the passed-in mapping that got unmapped) was not fully initialized. Specifically, br_state was not being copied from the passed-in struct to the uirec. This could lead to unpredictable results such as the reflinked mapping being marked unwritten in the destination file. Signed-off-by: Darrick J. Wong Reviewed-by: Brian Foster Signed-off-by: Sasha Levin --- fs/xfs/xfs_reflink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index f3c393f309e19..6622652a85a80 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1058,6 +1058,7 @@ xfs_reflink_remap_extent( uirec.br_startblock = irec->br_startblock + rlen; uirec.br_startoff = irec->br_startoff + rlen; uirec.br_blockcount = unmap_len - rlen; + uirec.br_state = irec->br_state; unmap_len = rlen; /* If this isn't a real mapping, we're done. */ -- 2.20.1