mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: xujialu <xujialu@vimux.org>
Cc: corbet@lwn.net, linux-kernel@vger.kernel.org,
	masahiroy@kernel.org, akpm@linux-foundation.org,
	mchehab+huawei@kernel.org
Subject: Re: [PATCH] scripts: gtags_files_generator.sh
Date: Sun, 26 Apr 2020 09:09:19 +0200	[thread overview]
Message-ID: <20200426070919.GB2084805@kroah.com> (raw)
In-Reply-To: <20200426024436.7534-1-xujialu@vimux.org>

On Sun, Apr 26, 2020 at 10:44:36AM +0800, xujialu wrote:
> Add a script to generate a more precise gtags.files from *.cmd files.
> 
> For navigating linux sources, it will be more efficient if gtags/cscope
> just collects source files that needed for compilation. The kernel
> makefiles already create *.cmd files that contain the files we needed,
> then just extracts files list from them and into gtags.files cause it's
> the the default name list file for gtags.
> 
> make defconfig
> make
> scripts/gtags_files_generator.sh
> gtags [-f gtags.files]
> 
> Enjoy with vim+gtags. :)
> 
> Here is a log for comparison with 'make gtags':
> 
> $ time make ARCH=arm cscope
>   GEN     cscope
> 
> real	1m20.600s
> user	1m36.004s
> sys	0m8.192s
> $ wc -l cscope.files
> 31201 cscope.files		#collected too many files we don't care
> 
> $ time ./scripts/gtags_files_generator.sh
> 
> Succeed, 3716 gtags.files listed!
> 
> real	0m1.593s		#collected files only we care
> user	0m1.704s
> sys	0m0.256s
> 				#collected also dts and dtsi
> $ grep dts gtags.files
> arch/arm/boot/dts/xxxxxx-clocks.dtsi
> arch/arm/boot/dts/xxxxxx.dtsi
> arch/arm/boot/dts/xxxxxxxx.dts
> arch/arm/boot/dts/xxxxxxxx.dtsi
> 
> Signed-off-by: xujialu <xujialu@vimux.org>
> ---
>  scripts/gtags_files_generator.sh | 48 ++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100755 scripts/gtags_files_generator.sh

As this is a new version, you need to properly version your patch, as is
documented, please do that.

Also, you seem to be ignoring my previous questions/comments, which
makes me want to just ignore this patch :(

greg k-h

  parent reply	other threads:[~2020-04-26  7:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200423095331.8032-1-xujialu@vimux.org>
2020-04-23 10:38 ` Greg KH
     [not found]   ` <20200423143642.11788-1-xujialu@vimux.org>
     [not found]     ` <20200423143642.11788-2-xujialu@vimux.org>
2020-04-23 14:42       ` Greg KH
2020-04-23 14:44       ` Jonathan Corbet
     [not found]       ` <20200425073105.27796-1-xujialu@vimux.org>
2020-04-25  8:03         ` Greg KH
     [not found]           ` <20200426024436.7534-1-xujialu@vimux.org>
2020-04-26  7:09             ` Greg KH [this message]
2020-04-26  7:46               ` xujialu
2020-04-26  8:36                 ` gregkh
     [not found]                   ` <20200428053509.19564-1-xujialu@vimux.org>
2020-04-28  7:04                     ` Greg KH
     [not found]                     ` <20200428053509.19564-2-xujialu@vimux.org>
2020-04-28  7:06                       ` [PATCH v2] scripts: scripts/tags.sh Greg KH
     [not found]                         ` <20200502052619.26457-1-xujialu@vimux.org>
     [not found]                           ` <20200502052619.26457-2-xujialu@vimux.org>
2020-05-12  2:51                             ` [PATCH v4 1/2] scripts: Support compiled source, improved precise Masahiro Yamada
     [not found]                               ` <20200514170945.24964-1-xujialu@vimux.org>
2020-05-21  6:29                                 ` Masahiro Yamada
     [not found]                           ` <20200502052619.26457-3-xujialu@vimux.org>
2020-05-12  3:08                             ` [PATCH v4 2/2] scripts: Add a intermediate file for 'make gtags' Masahiro Yamada
2020-04-28  7:52             ` [PATCH] scripts: gtags_files_generator.sh Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200426070919.GB2084805@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=xujialu@vimux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®