From: Jason Yan <yanaijie@huawei.com>
To: <gregkh@linuxfoundation.org>, <wambui.karugax@gmail.com>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Cc: Jason Yan <yanaijie@huawei.com>, Hulk Robot <hulkci@huawei.com>
Subject: [PATCH 1/7] staging: rtl8723bs: os_dep: remove set but not used 'uintRet'
Date: Mon, 27 Apr 2020 11:23:36 +0800 [thread overview]
Message-ID: <20200427032342.27211-2-yanaijie@huawei.com> (raw)
In-Reply-To: <20200427032342.27211-1-yanaijie@huawei.com>
Fix the following gcc warning:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2564:22: warning:
variable ‘uintRet’ set but not used [-Wunused-but-set-variable]
unsigned int uintRet = 0;
^~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 5059b874080e..902ac8169948 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2561,14 +2561,16 @@ static int rtw_wps_start(struct net_device *dev,
struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
struct iw_point *pdata = &wrqu->data;
u32 u32wps_start = 0;
- unsigned int uintRet = 0;
if ((true == padapter->bDriverStopped) || (true == padapter->bSurpriseRemoved) || (NULL == pdata)) {
ret = -EINVAL;
goto exit;
}
- uintRet = copy_from_user((void *)&u32wps_start, pdata->pointer, 4);
+ if (copy_from_user((void *)&u32wps_start, pdata->pointer, 4)) {
+ ret = -EFAULT;
+ goto exit;
+ }
if (u32wps_start == 0)
u32wps_start = *extra;
--
2.21.1
next prev parent reply other threads:[~2020-04-27 3:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 3:23 [PATCH 0/7] staging: rtl8723bs: some code cleanup Jason Yan
2020-04-27 3:23 ` Jason Yan [this message]
2020-04-28 12:27 ` [PATCH 1/7] staging: rtl8723bs: os_dep: remove set but not used 'uintRet' Greg KH
2020-04-27 3:23 ` [PATCH 2/7] staging: rtl8723bs: os_dep: remove set but not used 'size' Jason Yan
2020-04-28 12:28 ` Greg KH
2020-04-28 12:39 ` Jason Yan
2020-04-27 3:23 ` [PATCH 3/7] Staging: rtl8723bs: core: remove set but not used 'ptxservq' Jason Yan
2020-04-27 3:23 ` [PATCH 4/7] staging: rtl8723bs: core: remove set but not used 'algthm' Jason Yan
2020-04-27 3:23 ` [PATCH 5/7] staging: rtl8723bs: core: remove set but not used 'listen_interval' Jason Yan
2020-04-27 3:23 ` [PATCH 6/7] staging: rtl8723bs: core: remove set but not used 'pwrpriv' Jason Yan
2020-04-27 3:23 ` [PATCH 7/7] staging: rtl8723bs: core: remove set but not used 'pframe' Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427032342.27211-2-yanaijie@huawei.com \
--to=yanaijie@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®