From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1A2C83002 for ; Tue, 28 Apr 2020 02:31:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20CA3206D6 for ; Tue, 28 Apr 2020 02:31:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="OkkN9xIi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbgD1CbI (ORCPT ); Mon, 27 Apr 2020 22:31:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726271AbgD1CbH (ORCPT ); Mon, 27 Apr 2020 22:31:07 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51C40C03C1A9 for ; Mon, 27 Apr 2020 19:31:07 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id l11so15579173lfc.5 for ; Mon, 27 Apr 2020 19:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=UnerS2Kl72hAiRVV2JqGYkvblu54baNutnPShcz46io=; b=OkkN9xIiD9FngwwvJ3pMdyLdtg67Z2MwQTMlMe6MrvEB2ZVVWlYv4L+ca0Hmi7XN7y jbwJyLyHnFXhV0d6E3dpbxnZ3v9JR0TLHFPKmj32jKc4uXsBEgXoW6uF1ZB/+4gTRy7z C2Ycvdhf7h8TwhdblEdv56naB8mZRzXxFKVkLAUvivV1bCKdLkHYouFPJO7OoMj1yA4y XmYDouhnciLHkfCLGz6NZjMECvbK6d4QUtqAEWB1rGHlFavbRH8mUQXXDRi8Z/te+OMF /f+BZbyIT7HxHM4WSkA6gjeX+lpVV6rbMqfdIMH3/+Xfg1t6C6xDc797soeK5bDzRNnh ISvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=UnerS2Kl72hAiRVV2JqGYkvblu54baNutnPShcz46io=; b=SGXdtk77wVvK2Qtj4G+OijlTwUyjnjVZQJR3ZYxmRI7qYNrH0z4kO5e2xAYwshaPhN YXoGhEibmoCgzcxN79/s7tBdBSVX+buCvjdunuezGscTh2LFzH8zVFSVV2GebjfspIGW PGI/N7lbbJwC1dJioAkopb1e4u9wMOmu7pEb8/mmSw+/+9TnjOAVKoMqeupEMEsU2VXc p8hhB7JDQna5M3EaQaRLjQh56ihBGklM/X8fyY4hNgAW0KONiAiKnNShAtrugv50398q u8oZmZ38vAoGAa08ZXhmrXkEkwTImLfCyDJxkmKtEG5RnybGDiBlbJqcQlJTLAt+RmGC 6Tvw== X-Gm-Message-State: AGi0PubITKyTLwq1c6VeqlnDwDSjN4H32q+61HNFoaShQokg2YlgURtw HMcWXOOH9pnx3pc5kjzAdP8zQA== X-Google-Smtp-Source: APiQypIj0PB/FA6x9NNYsA6QIcOzjetw0kg/v5q+6OcjxSFRTOLA0AMLTRjmkTIXCvBWJdctSvaREw== X-Received: by 2002:a19:4b90:: with SMTP id y138mr17072981lfa.39.1588041065784; Mon, 27 Apr 2020 19:31:05 -0700 (PDT) Received: from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203]) by smtp.gmail.com with ESMTPSA id v17sm12758148lfe.34.2020.04.27.19.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 19:31:05 -0700 (PDT) Date: Tue, 28 Apr 2020 04:31:04 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Daniel Lezcano , Thomas Gleixner , Rob Herring , Chris Brandt , devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: timer: renesas: ostm: Convert to json-schema Message-ID: <20200428023104.GD1208690@oden.dyn.berto.se> References: <20200427193224.29548-1-geert+renesas@glider.be> <20200428022904.GC1208690@oden.dyn.berto.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200428022904.GC1208690@oden.dyn.berto.se> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi (again) Geert, On 2020-04-28 04:29:05 +0200, Niklas Söderlund wrote: > Hi Geert, > > Thanks for your patch. > > On 2020-04-27 21:32:24 +0200, Geert Uytterhoeven wrote: > > Convert the Renesas OS Timer (OSTM) Device Tree binding documentation to > > json-schema. > > > > Document missing properties. > > > > Signed-off-by: Geert Uytterhoeven > > Reviewed-by: Niklas Söderlund Sometimes I type quicker then I think (which is not such a difficult taks), that should have been. Reviewed-by: Niklas Söderlund > > > --- > > For a clean dtbs_check, this depends on "[PATCH] ARM: dts: r7s9210: Remove > > bogus clock-names from OSTM nodes" > > (https://lore.kernel.org/r/20200427192932.28967-1-geert+renesas@glider.be) > > which I intend to queue as a fix for v5.7. > > > > .../bindings/timer/renesas,ostm.txt | 31 ---------- > > .../bindings/timer/renesas,ostm.yaml | 59 +++++++++++++++++++ > > 2 files changed, 59 insertions(+), 31 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.txt > > create mode 100644 Documentation/devicetree/bindings/timer/renesas,ostm.yaml > > > > diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.txt b/Documentation/devicetree/bindings/timer/renesas,ostm.txt > > deleted file mode 100644 > > index 81a78f8bcf170a82..0000000000000000 > > --- a/Documentation/devicetree/bindings/timer/renesas,ostm.txt > > +++ /dev/null > > @@ -1,31 +0,0 @@ > > -* Renesas OS Timer (OSTM) > > - > > -The OSTM is a multi-channel 32-bit timer/counter with fixed clock > > -source that can operate in either interval count down timer or free-running > > -compare match mode. > > - > > -Channels are independent from each other. > > - > > -Required Properties: > > - > > - - compatible: must be one or more of the following: > > - - "renesas,r7s72100-ostm" for the R7S72100 (RZ/A1) OSTM > > - - "renesas,r7s9210-ostm" for the R7S9210 (RZ/A2) OSTM > > - - "renesas,ostm" for any OSTM > > - This is a fallback for the above renesas,*-ostm entries > > - > > - - reg: base address and length of the register block for a timer channel. > > - > > - - interrupts: interrupt specifier for the timer channel. > > - > > - - clocks: clock specifier for the timer channel. > > - > > -Example: R7S72100 (RZ/A1H) OSTM node > > - > > - ostm0: timer@fcfec000 { > > - compatible = "renesas,r7s72100-ostm", "renesas,ostm"; > > - reg = <0xfcfec000 0x30>; > > - interrupts = ; > > - clocks = <&mstp5_clks R7S72100_CLK_OSTM0>; > > - power-domains = <&cpg_clocks>; > > - }; > > diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml > > new file mode 100644 > > index 0000000000000000..600d47ab7d58570f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/timer/renesas,ostm.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas OS Timer (OSTM) > > + > > +maintainers: > > + - Chris Brandt > > + - Geert Uytterhoeven > > + > > +description: > > + The OSTM is a multi-channel 32-bit timer/counter with fixed clock source that > > + can operate in either interval count down timer or free-running compare match > > + mode. > > + > > + Channels are independent from each other. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - renesas,r7s72100-ostm # RZ/A1H > > + - renesas,r7s9210-ostm # RZ/A2M > > + - const: renesas,ostm # Generic > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + power-domains: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - power-domains > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + ostm0: timer@fcfec000 { > > + compatible = "renesas,r7s72100-ostm", "renesas,ostm"; > > + reg = <0xfcfec000 0x30>; > > + interrupts = ; > > + clocks = <&mstp5_clks R7S72100_CLK_OSTM0>; > > + power-domains = <&cpg_clocks>; > > + }; > > -- > > 2.17.1 > > > > -- > Regards, > Niklas Söderlund -- Regards, Niklas Söderlund