From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, acme@redhat.com, jolsa@redhat.com,
irogers@google.com, kan.liang@intel.com
Subject: Re: [PATCH] perf/script: remove extraneous newline in perf_sample__fprintf_regs()
Date: Mon, 27 Apr 2020 19:47:44 -0700 [thread overview]
Message-ID: <20200428024744.GA703870@tassilo.jf.intel.com> (raw)
In-Reply-To: <20200418231908.152212-1-eranian@google.com>
On Sat, Apr 18, 2020 at 04:19:08PM -0700, Stephane Eranian wrote:
> When printing iregs, there was a double newline printed because
> perf_sample__fprintf_regs() was printing its own and then at the
> end of all fields, perf script was adding one.
> This was causing blank line in the output:
I don't think the patch is quite correct because there could be
other fields after it, and they need to be separated by a
new line too.
e.g. i suspect if someone prints iregs,uregs or iregs,brstack
or something else that is printed in process_event after *regs
you would get garbled output.
So you have to track if the newline is needed or not.
-Andi
next prev parent reply other threads:[~2020-04-28 2:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 23:19 Stephane Eranian
2020-04-27 21:43 ` Stephane Eranian
2020-04-28 12:29 ` Arnaldo Carvalho de Melo
2020-04-28 2:47 ` Andi Kleen [this message]
2020-04-29 19:32 ` Stephane Eranian
2020-04-30 2:09 ` Andi Kleen
2020-04-30 2:13 ` Stephane Eranian
2020-05-08 13:05 ` [tip: perf/core] perf script: Remove " tip-bot2 for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428024744.GA703870@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome