From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD79EC83004 for ; Wed, 29 Apr 2020 07:26:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A451920775 for ; Wed, 29 Apr 2020 07:26:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="V7V1P9rM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbgD2H0b (ORCPT ); Wed, 29 Apr 2020 03:26:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726355AbgD2H0a (ORCPT ); Wed, 29 Apr 2020 03:26:30 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 855A6C03C1AD; Wed, 29 Apr 2020 00:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LGUajY3zrEqlVG97WYEWRDf+dd4RxLtAou449QsqwG8=; b=V7V1P9rMO8ynOmu1ucNMN2K119 1XXWnJHB7kYIapdre1i+SIFMTjhfsPMlUUjHKR2Am/uBfX3nrnes6gpWaEUSXpOQa+g3dy7a/79gd vddgtayQBI9AgCBhiUnpYZmztiqUj4p1rViwVd1vFelA5QwoBFU8Ryuuddxb7MMtpVHrg/F+UE+6/ YS/VTznhQ/FgzibxcCyA7hSYcqmjPiOm8b375zpibp11Y3ZWfTDt7JSkQC+0Mt/VKyDUt+/uN7FEI 3Tcl6mJeoqbrpBGeBBtB88UBQVwm/3ncSzS+7SM5sU+7lzSBvbu/ayRY44VyMiHEpikGZc+hXlsQQ EvujYA5w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTh6z-0000w9-VV; Wed, 29 Apr 2020 07:26:29 +0000 Date: Wed, 29 Apr 2020 00:26:29 -0700 From: Christoph Hellwig To: Zou Wei Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] blk-mq: Use BUG_ON() instead of BUG() Message-ID: <20200429072629.GE11410@infradead.org> References: <1588126224-47877-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588126224-47877-1-git-send-email-zou_wei@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 10:10:24AM +0800, Zou Wei wrote: > Fixes coccicheck warning: > > block/blk-mq.c:546:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. > > Fixes: 63151a449eba ("blk-mq: allow drivers to hook into I/O completion") > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > block/blk-mq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index bcc3a23..49a227e 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -542,8 +542,7 @@ EXPORT_SYMBOL(__blk_mq_end_request); > > void blk_mq_end_request(struct request *rq, blk_status_t error) > { > - if (blk_update_request(rq, error, blk_rq_bytes(rq))) > - BUG(); > + BUG_ON(blk_update_request(rq, error, blk_rq_bytes(rq))); I don't think hiding something that actually does do the work in a BUG_ON ever is a good style.