From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB8BCC83003 for ; Wed, 29 Apr 2020 08:48:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93FED20787 for ; Wed, 29 Apr 2020 08:48:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="RtPHj/Nl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726564AbgD2Iss (ORCPT ); Wed, 29 Apr 2020 04:48:48 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:24216 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbgD2Iss (ORCPT ); Wed, 29 Apr 2020 04:48:48 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03T8logm017993; Wed, 29 Apr 2020 03:47:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=wg0rOWzlWFXEP48Zt5Zht4FjVgU4+4tJHUQA+GsEaYo=; b=RtPHj/Nli1Q2cfdMZ1oucOKAqHi1PVoSZtxTWDxaFXpSzlV4E7DfvPa8LXeDaH8l10LF SYK5IimHdi7pgNJoxvT8GIxzBh9x5ndjSdr03LwWfFbrw02M1WTf/6GCInJEpMTpQIBO 4p55ic4vyI+wN/JPLj5Ua1DfoA94d6CZuWpGz7yfBFzi4TxYNYNY8es9ys01vK/h4b8y hz0rsV5CHZgdFSj32lokmhU8ckl2YRKcl/JI+wdLiW2r7vqlteB2dnp1ydxd4tJFKvR5 2O1g1p9QoofGbamGvhdnPXsQh60OwCnlVaRQcQes9QP63GR6hyPMYofij/afR8Mb4vbh dw== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 30mhmqxhee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 29 Apr 2020 03:47:50 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Wed, 29 Apr 2020 09:47:48 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Wed, 29 Apr 2020 09:47:48 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id A3F472C5; Wed, 29 Apr 2020 08:47:48 +0000 (UTC) Date: Wed, 29 Apr 2020 08:47:48 +0000 From: Charles Keepax To: Arnd Bergmann CC: Mark Brown , Randy Dunlap , Geert Uytterhoeven , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Richard Fitzgerald , , Subject: Re: [PATCH] ASoC: codecs: wm97xx: fix ac97 dependency Message-ID: <20200429084748.GO44490@ediswmail.ad.cirrus.com> References: <20200428212721.2877627-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200428212721.2877627-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com ip4:5.172.152.52 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=981 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004290073 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 11:26:59PM +0200, Arnd Bergmann wrote: > A recent build fix got the dependency slightly wrong, breaking > builds with CONFIG_AC97_BUS_NEW: > > WARNING: unmet direct dependencies detected for SND_SOC_WM9713 > Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AC97_BUS [=n] > Selected by [m]: > - SND_SOC_ZYLONITE [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_PXA2XX_SOC [=m] && MACH_ZYLONITE [=y] && AC97_BUS [=n]=n > > WARNING: unmet direct dependencies detected for SND_SOC_WM9712 > Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AC97_BUS [=n] > Selected by [m]: > - SND_PXA2XX_SOC_EM_X270 [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_PXA2XX_SOC [=m] && (MACH_EM_X270 [=n] || MACH_EXEDA [=n] || MACH_CM_X300 [=y]) && AC97_BUS [=n]=n > > Change the dependency to allow either version of the AC97 library > code. > > Fixes: 5a309875787d ("ASoC: Fix SND_SOC_ALL_CODECS imply ac97 fallout") > Signed-off-by: Arnd Bergmann > --- Acked-by: Charles Keepax Thanks, Charles